Page MenuHomePhabricator
Differential D13259

[lib] Fix sendnig create_sidebar to peers
ClosedPublic
Actions

Authored by inka on Fri, Sep 6, 6:52 AM.
Tags
None
Referenced Files
F2754972: D13259.diff
Wed, Sep 18, 9:14 PM
F2753952: D13259.id44084.diff
Wed, Sep 18, 6:32 PM
Unknown Object (File)
Tue, Sep 17, 11:48 AM
Unknown Object (File)
Mon, Sep 16, 5:09 AM
Unknown Object (File)
Sun, Sep 15, 12:32 PM
Unknown Object (File)
Sat, Sep 14, 3:04 PM
Unknown Object (File)
Sat, Sep 14, 5:58 AM
Unknown Object (File)
Fri, Sep 13, 11:33 AM
View All 15 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM4a9159903769: [lib] Fix sendnig create_sidebar to peers
Summary

issue: ENG-9134
For sidebars we should also inform the members of the parent about thier creation

Test Plan

Tested that now when a sidebar is created in a thick thread, other members of the thick thread are informed

Diff Detail

Repository
rCOMM Comm
Branch
inka/thread_ops
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Fri, Sep 6, 6:52 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 6, 6:52 AM
Harbormaster completed remote builds in B31459: Diff 43925.Fri, Sep 6, 7:14 AM
inka requested review of this revision.Fri, Sep 6, 7:14 AM
inka added a parent revision: D13258: [lib][native] Review usingOlmViaTunnelbrokerForDMs and pendingThreadType.Fri, Sep 6, 7:40 AM
inka mentioned this in D13253: [lib][web][native] Update createPendingThread usages.
tomek accepted this revision.Fri, Sep 6, 7:43 AM
tomek added inline comments.
lib/hooks/thread-search-hooks.js
114

How about renaming it?

134–138

We shouldn't include the members here - they are already included in the parent thread's members list.

This revision is now accepted and ready to land.Fri, Sep 6, 7:43 AM
inka added a child revision: D13266: [lib] Update existingThreadInfoFinder to handle thick threads.Mon, Sep 9, 3:09 AM
inka updated this revision to Diff 44084.Thu, Sep 12, 7:12 AM

Address review

Harbormaster completed remote builds in B31566: Diff 44084.Thu, Sep 12, 7:29 AM
Closed by commit rCOMM4a9159903769: [lib] Fix sendnig create_sidebar to peers (authored by inka). · Explain WhyThu, Sep 12, 8:04 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM4a9159903769: [lib] Fix sendnig create_sidebar to peers.

Revision Contents
Changeset List

PathSize
lib/
hooks/
12 lines

Diff 43925

View Options

lib/hooks/thread-search-hooks.js

Loading...