pretty self-explanatory. only the primary device should be able to remove other devices. we hide the remove device button if user is not on their primary device.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/profile/linked-devices-list-item.react.js | ||
---|---|---|
20–22 | Can't you reuse isPrimary? Their values should be equal | |
native/profile/linked-devices.react.js | ||
38–40 | Not sure which way of determining primary device is better:
| |
65 | Nit, kinda unrelated: if we need only deviceID, getContentSigningKey() doesn't require Identity context |