[lib][native][web] send encrypted dms on web and native when deleting on thick threads
ClosedPublic
Actions

Authored by will on Sep 16 2024, 1:26 AM.

Details

Reviewers

marcin
tomek
ashoat

Commits

rCOMMcbcdc8c9db6e: [lib][native][web] send encrypted dms on web and native when deleting on thick…

Summary

Sends encrypted dms when deleting entries in a thick thread

Depends on D13344

Test Plan

test plan similar as previous. Four platforms with two accounts in-between them all in a thick thread. Deleted entries and confirmed they deleted on all four platforms

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Sep 16 2024, 1:26 AM

will added a child revision: D13346: [lib] extend ProcessDMOperationUtilities to include entryInfos.Sep 16 2024, 1:36 AM

will edited the summary of this revision. (Show Details)Sep 16 2024, 1:39 AM

will added a parent revision: D13343: [lib][native][web] send encrypted dms on web and native for create entry.

will edited the summary of this revision. (Show Details)

will added a parent revision: D13344: [lib][native][web] send encrypted dms on web and native when editing entries on thick threads.

will removed a parent revision: D13343: [lib][native][web] send encrypted dms on web and native for create entry.

Harbormaster completed remote builds in B31627: Diff 44199.Sep 16 2024, 1:55 AM

will requested review of this revision.Sep 16 2024, 1:55 AM

tomek requested changes to this revision.Sep 16 2024, 5:39 AM

tomek added inline comments.

lib/actions/entry-actions.js
449 ↗	(On Diff #44199)	This can get confused with the entry's timestamp.
lib/types/dm-ops.js
404–418 ↗	(On Diff #44199)	Can we keep the shape consistent with all the other operations and keep the timestamp in `time` property? What do these two timestamps mean?