[blob] New endpoint to batch-add holders
ClosedPublic
Actions

Authored by bartek on Sep 26 2024, 12:23 AM.

Details

Reviewers

will
kamil
marcin
tomek

Commits

rCOMMf8deb7ba706e: [blob] New endpoint to batch-add holders

Summary

Address ENG-9356.

Created POST /holders endpoint on Blob Service.
Request is a list of blobHash-holder pairs.
Response is a list of results for each pair: blobHash, holder, dataExists, holderAlreadyExists, success

Depends on D13479

Test Plan

Ran Blob locally and used Postman to add some holders. To verify returned booleans, mixed this endpoint calls with calling single-blob endpoints to upload blobs, add/remove holders

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 26 2024, 12:23 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 26 2024, 12:23 AM

bartek added a child revision: D13481: [blob] Batch check if blob exists.Sep 26 2024, 12:35 AM

Harbormaster completed remote builds in B31866: Diff 44584.Sep 26 2024, 12:40 AM

bartek edited reviewers, added: tomek; removed: varun.Sep 26 2024, 12:47 AM

bartek published this revision for review.Sep 26 2024, 12:52 AM

bartek added inline comments.

services/blob/src/http/handlers/holders.rs
21–34 ↗	(On Diff #44584)	Decided to use 1st proposal from the Linear discussion
50 ↗	(On Diff #44584)	Similarly to https://phab.comm.dev/D13479?id=44583#inline-77134 it is done in a loop because of underlying transactions, but could be improved if needed. In further diffs in this stack, I partially improve this by batch-getting `data_exists`