[lib] Including pending thread for viewer in useThreadListSearch
ClosedPublic
Actions

Authored by ashoat on Mon, Sep 30, 9:48 PM.

Details

Reviewers

tomek
kamil
inka

Commits

rCOMMde8c28384472: [lib] Including pending thread for viewer in useThreadListSearch

Summary

Before this work, we always had a GENESIS_PRIVATE thread for the viewer, so we had no reason to support pending private threads in useThreadListSearch.

Now we would like to support that. We'll show a pending private thread only if no private thread exists.

Depends on D13536

Test Plan

In combination with the rest of the stack, test creating a PRIVATE thread via thread list search on both web and native

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mon, Sep 30, 9:48 PM

ashoat added a child revision: D13538: [lib] Handle private threads differently from personal ones in thread list search.

Harbormaster completed remote builds in B31953: Diff 44718.Mon, Sep 30, 10:17 PM

ashoat requested review of this revision.Mon, Sep 30, 10:17 PM

tomek accepted this revision.Tue, Oct 1, 8:41 AM

This revision is now accepted and ready to land.Tue, Oct 1, 8:41 AM

Closed by commit rCOMMde8c28384472: [lib] Including pending thread for viewer in useThreadListSearch (authored by ashoat). · Explain WhyTue, Oct 1, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMde8c28384472: [lib] Including pending thread for viewer in useThreadListSearch.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

thread-search-hooks.js

15 lines

shared/

search-utils.js

13 lines

Diff 44718

View Options

lib/hooks/thread-search-hooks.js