Page MenuHomePhabricator

[native][web] Only show viewer in chat composer results when empty
ClosedPublic

Authored by ashoat on Mon, Sep 30, 10:00 PM.
Tags
None
Referenced Files
F2860683: D13543.diff
Tue, Oct 1, 7:24 PM
F2860575: D13543.diff
Tue, Oct 1, 6:28 PM
F2860458: D13543.id44724.diff
Tue, Oct 1, 5:59 PM
F2860429: D13543.id.diff
Tue, Oct 1, 5:50 PM
F2860096: D13543.id44724.diff
Tue, Oct 1, 3:45 PM
F2860040: D13543.id.diff
Tue, Oct 1, 3:32 PM
F2853626: D13543.id44724.diff
Mon, Sep 30, 10:29 PM
F2853531: D13543.id.diff
Mon, Sep 30, 10:27 PM
Subscribers
None

Details

Summary

If the user has selected somebody other than themselves to chat with, we'll exclude the viewer from the results.

In other words, we'll only show the viewer as an option to themselves when the list is empty.

We're doing this because we want to treat this case similarly to when the viewer selects a non-friend: instead of letting them include themselves in the list, we will just open directly to the PRIVATE if the user select themselves at the start (D13545), and not list them as an option if they select somebody else at the start (this diff).

Depends on D13542

Test Plan

Confirm that if the viewer adds somebody to the list of pending members, they can no longer see themselves in the list of potential pending members

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable