Page MenuHomePhabricator
Differential D13548

[lib] Allow calling createRealThreadFromPendingThread for PRIVATE thread
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 4:35 PM
Unknown Object (File)
Thu, Apr 17, 3:22 AM
Unknown Object (File)
Wed, Apr 16, 6:57 PM
Unknown Object (File)
Wed, Apr 16, 10:20 AM
Unknown Object (File)
Thu, Apr 3, 11:09 PM
Unknown Object (File)
Thu, Mar 27, 12:49 AM
Unknown Object (File)
Mar 16 2025, 2:47 AM
Unknown Object (File)
Feb 28 2025, 8:05 PM
View All 51 Files
Subscribers
None

Details

Reviewers
tomek
kamil
inka
Commits
rCOMM11fd8ad3f62f: [lib] Allow calling createRealThreadFromPendingThread for PRIVATE thread
Summary

Not sure why this invariant is here (added in D13244), but I tested and it all works correctly after removing it.

Depends on D13547

Test Plan

On both native and web, tested PRIVATE thread creation end-to-end via thread list search, chat composer, and user profile. Confirmed that a peer (same user device) receives the DM messages

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
70 lines

Diff 44729

View Options

lib/shared/thread-actions-utils.js

Show First 20 Lines • Show All 417 Lines • ▼ Show 20 Lines ) {
const lateResponsesSet = new Set<number>( const lateResponsesSet = new Set<number>(
state.keyserverInfos[keyserverID].connection.lateResponses, state.keyserverInfos[keyserverID].connection.lateResponses,
); );
if (isLate) { if (isLate) {
lateResponsesSet.add(messageID); lateResponsesSet.add(messageID);
} else { } else {
lateResponsesSet.delete(messageID); lateResponsesSet.delete(messageID);
} }
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
lateResponses: [...lateResponsesSet], lateResponses: [...lateResponsesSet],
}, },
}, },
}, },
}; };
} else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
return { return {
...state, ...state,
keyserverInfos: { keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
...state.keyserverInfos, };
[keyserverID]: { } else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
const operation: ReplaceKeyserverOperation = {
type: 'replace_keyserver',
payload: {
id: keyserverID,
keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
showDisconnectedBar: action.payload.visible, showDisconnectedBar: action.payload.visible,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} else if (action.type === setDeviceTokenActionTypes.success) { } else if (action.type === setDeviceTokenActionTypes.success) {
const { deviceTokens } = action.payload; const { deviceTokens } = action.payload;
const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos }; const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos };
for (const keyserverID in deviceTokens) { for (const keyserverID in deviceTokens) {
keyserverInfos[keyserverID] = { keyserverInfos[keyserverID] = {
...keyserverInfos[keyserverID], ...keyserverInfos[keyserverID],
deviceToken: deviceTokens[keyserverID], deviceToken: deviceTokens[keyserverID],
}; };
} }
return { return {
...state, ...state,
keyserverInfos, keyserverInfos,
}; };
} else if (action.type === setConnectionIssueActionType) { } else if (action.type === setConnectionIssueActionType) {
const { connectionIssue, keyserverID } = action.payload; const { connectionIssue, keyserverID } = action.payload;
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
connectionIssue, connectionIssue,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} }
return state; return state;
} }