[lib] Allow calling createRealThreadFromPendingThread for PRIVATE thread
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:08 PM.

Details

Reviewers

tomek
kamil
inka

Commits

rCOMM11fd8ad3f62f: [lib] Allow calling createRealThreadFromPendingThread for PRIVATE thread

Summary

Not sure why this invariant is here (added in D13244), but I tested and it all works correctly after removing it.

Depends on D13547

Test Plan

On both native and web, tested PRIVATE thread creation end-to-end via thread list search, chat composer, and user profile. Confirmed that a peer (same user device) receives the DM messages

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 30 2024, 10:08 PM

ashoat added a child revision: D13549: [web] Update thick threads avatar logic for web.

ashoat edited the summary of this revision. (Show Details)Sep 30 2024, 10:56 PM

Harbormaster completed remote builds in B31964: Diff 44729.Sep 30 2024, 11:11 PM

ashoat requested review of this revision.Sep 30 2024, 11:11 PM

tomek accepted this revision.Oct 1 2024, 8:16 AM

This revision is now accepted and ready to land.Oct 1 2024, 8:16 AM

Closed by commit rCOMM11fd8ad3f62f: [lib] Allow calling createRealThreadFromPendingThread for PRIVATE thread (authored by ashoat). · Explain WhyOct 1 2024, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM11fd8ad3f62f: [lib] Allow calling createRealThreadFromPendingThread for PRIVATE thread.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-actions-utils.js

70 lines

Diff 44729

View Options

lib/shared/thread-actions-utils.js

[lib] Allow calling createRealThreadFromPendingThread for PRIVATE threadClosedPublicActions