Page MenuHomePhabricator

[native] Improve device labels on device list screen
AcceptedPublic

Authored by bartek on Thu, Oct 17, 7:43 AM.

Details

Reviewers
ashoat
varun
Summary

Resolves ENG-9136

The previous label for current primary device looked weird with two parentheses:

someDeviceID (primary) (this device)

Depends on D13262

Test Plan
  • Opened devices screen on native and verified they're now displayed correctly
  • JS playground:
function getLabel(deviceID, isPrimary, isThisDevice) {
  // contents of useMemo
}

getLabel('123456789', false, false) // '1234567'
getLabel('123456789', false, true)  // '1234567 (this device)'
getLabel('123456789', true, false)  // '1234567 (primary)'
getLabel('123456789', true, true)   // '1234567 (primary, this device)'

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D13262
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Can you share a screenshot of what it looks like now in the Test Plan?

This revision is now accepted and ready to land.Thu, Oct 17, 9:03 AM