Differential D13747

[native] Improve device labels on device list screen
ClosedPublic
Actions

Authored by bartek on Oct 17 2024, 7:43 AM.

Tags

None

Referenced Files

	F3333129: D13747.diff
	Thu, Nov 21, 3:49 AM

	Unknown Object (File)
	Wed, Nov 20, 3:42 AM

	Unknown Object (File)
	Wed, Nov 20, 3:41 AM

	Unknown Object (File)
	Wed, Nov 20, 2:44 AM

	Unknown Object (File)
	Mon, Nov 18, 5:02 PM

	Unknown Object (File)
	Fri, Nov 15, 2:54 AM

	Unknown Object (File)
	Fri, Nov 15, 2:05 AM

	Unknown Object (File)
	Thu, Nov 14, 10:13 PM

View All 31 Files

Subscribers

Details

Reviewers

ashoat
varun

Commits

rCOMM085f43d75697: [native] Improve device labels on device list screen

Summary

Resolves ENG-9136

The previous label for current primary device looked weird with two parentheses:

someDeviceID (primary) (this device)

Depends on D13262

Test Plan

Opened devices screen on native and verified they're now displayed correctly

Simulator Screenshot - iPhone 15 Pro - 2024-10-18 at 10.55.22.png (2×1 px, 188 KB)

JS playground:

function getLabel(deviceID, isPrimary, isThisDevice) {
  // contents of useMemo
}

getLabel('123456789', false, false) // '1234567'
getLabel('123456789', false, true)  // '1234567 (this device)'
getLabel('123456789', true, false)  // '1234567 (primary)'
getLabel('123456789', true, true)   // '1234567 (primary, this device)'

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 17 2024, 7:43 AM

Herald added a subscriber: tomek. · View Herald TranscriptOct 17 2024, 7:43 AM

Harbormaster completed remote builds in B32298: Diff 45268.Oct 17 2024, 8:01 AM

bartek requested review of this revision.Oct 17 2024, 8:01 AM

Can you share a screenshot of what it looks like now in the Test Plan?

This revision is now accepted and ready to land.Oct 17 2024, 9:03 AM

bartek mentioned this in D13125: [native] add ability to remove devices from linked devices bottom sheet.Oct 18 2024, 2:22 AM

bartek edited the test plan for this revision. (Show Details)Oct 18 2024, 2:33 AM

bartek attached a referenced file: F3000688: Simulator Screenshot - iPhone 15 Pro - 2024-10-18 at 10.55.22.png. (Show Details)

Rebase

Harbormaster completed remote builds in B32519: Diff 45585.Mon, Nov 4, 10:29 AM

Closed by commit rCOMM085f43d75697: [native] Improve device labels on device list screen (authored by bartek). · Explain WhyFri, Nov 8, 6:25 AM

This revision was automatically updated to reflect the committed changes.

bartek mentioned this in rCOMMa4517c9d13ba: [native] add ability to remove devices from linked devices bottom sheet.

bartek added a commit: rCOMM085f43d75697: [native] Improve device labels on device list screen.

Revision Contents
Changeset List

Path

Size

native/

profile/

linked-devices-list-item.react.js

13 lines

Diff 45720

native/profile/linked-devices-list-item.react.js

Loading...