Page MenuHomePhabricator
Differential D13959

[lib] Extract function to assign holder
ClosedPublic
Actions

Authored by bartek on Nov 18 2024, 6:52 AM.
Tags
None
Referenced Files
F3517044: D13959.id.diff
Sun, Dec 22, 4:10 PM
Unknown Object (File)
Wed, Dec 18, 5:06 PM
Unknown Object (File)
Wed, Dec 18, 4:12 PM
Unknown Object (File)
Mon, Dec 16, 4:58 PM
Unknown Object (File)
Mon, Dec 16, 11:32 AM
Unknown Object (File)
Mon, Dec 16, 2:22 AM
Unknown Object (File)
Mon, Dec 16, 2:22 AM
Unknown Object (File)
Sun, Dec 15, 1:42 AM
View All 37 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
ashoat
Commits
rCOMMffdfcb7c95b8: [lib] Extract function to assign holder
Summary

Preparation for ENG-9526.
Replaced direct calls of fetch() with a dedicated function. It makes it easier to handle specific response code for invalid CSAT.

Depends on D13958

Test Plan

Flow, eslint, manual testing

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 18 2024, 6:52 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 18 2024, 6:52 AM
bartek added a child revision: D13960: [lib] Extract function to remove holder.Nov 18 2024, 6:52 AM
Harbormaster completed remote builds in B32700: Diff 45866.Nov 18 2024, 1:01 PM
bartek published this revision for review.Nov 21 2024, 4:28 AM
ashoat accepted this revision.Nov 21 2024, 4:45 PM
ashoat added inline comments.
keyserver/src/services/blob.js
116 ↗(On Diff #45866)

I'm confused how this wasn't causing ESLint errors earlier

lib/utils/blob-service.js
148 ↗(On Diff #45866)

Inputs should (usually) be read-only

This revision is now accepted and ready to land.Nov 21 2024, 4:45 PM
ashoat mentioned this in D13992: [native][web] Handle invalid CSAT in input-state-containers.Mon, Nov 25, 5:52 AM
bartek added inline comments.Tue, Nov 26, 4:10 AM
keyserver/src/services/blob.js
116 ↗(On Diff #45866)

Answered in https://phab.comm.dev/D13989#inline-78783

lib/utils/blob-service.js
148 ↗(On Diff #45866)

https://phab.comm.dev/D13958#inline-78842

bartek updated this revision to Diff 46053.Tue, Nov 26, 4:10 AM

Rebase

Harbormaster completed remote builds in B32838: Diff 46053.Tue, Nov 26, 4:29 AM
ashoat accepted this revision.Tue, Nov 26, 5:18 AM

Thanks for explaining!

Closed by commit rCOMMffdfcb7c95b8: [lib] Extract function to assign holder (authored by bartek). · Explain WhyFri, Nov 29, 5:02 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMffdfcb7c95b8: [lib] Extract function to assign holder.

Revision Contents
Changeset List

PathSize
keyserver/
src/
services/
22 lines
lib/
actions/
52 lines
utils/
32 lines
8 lines

Diff 46134

View Options

keyserver/src/services/blob.js

Loading...
View Options

lib/actions/upload-actions.js

Loading...
View Options

lib/utils/blob-service.js

Loading...
View Options

lib/utils/services-utils.js

Loading...