Paths

Table of Contentst

Differential D13990

[lib][keyserver] Handle invalid CSAT for multi-holder actions
ClosedPublic
Actions

Authored by bartek on Nov 21 2024, 3:59 AM.

Tags

None

Referenced Files

	F3518551: D13990.id45921.diff
	Sun, Dec 22, 8:21 PM

	F3518010: D13990.id.diff
	Sun, Dec 22, 6:56 PM

	Unknown Object (File)
	Mon, Dec 16, 11:00 AM

	Unknown Object (File)
	Mon, Dec 16, 2:14 AM

	Unknown Object (File)
	Mon, Dec 16, 2:14 AM

	Unknown Object (File)
	Sun, Dec 15, 4:52 AM

	Unknown Object (File)
	Thu, Dec 5, 3:18 PM

	Unknown Object (File)
	Thu, Dec 5, 12:48 AM

View All 25 Files

Subscribers

Details

Reviewers

kamil
varun
ashoat

Commits

rCOMMf4e33a13ca08: [lib][keyserver] Handle invalid CSAT for multi-holder actions

Summary

Part of ENG-9526

Depends on D13989

Test Plan

Manual testing with mocked invalid access token

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Nov 21 2024, 3:59 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 21 2024, 3:59 AM

bartek added a child revision: D13991: [native][web] Handle invalid CSAT in fetchAndDecryptMedia.Nov 21 2024, 4:00 AM

Harbormaster completed remote builds in B32746: Diff 45921.Nov 21 2024, 4:23 AM

bartek published this revision for review.Sun, Nov 24, 11:01 PM

bartek edited the test plan for this revision. (Show Details)Sun, Nov 24, 11:24 PM

ashoat requested changes to this revision.Mon, Nov 25, 5:49 AM

ashoat added inline comments.

lib/actions/holder-actions.js
58 ↗	(On Diff #45921)	Why is this optional?
109 ↗	(On Diff #45921)	Why is this optional?
152 ↗	(On Diff #45921)	Why are we not passing `invalidTokenLogOut` here?

This revision now requires changes to proceed.Mon, Nov 25, 5:49 AM

bartek added inline comments.Mon, Nov 25, 7:10 AM

lib/actions/holder-actions.js
58 ↗	(On Diff #45921)	To skip handling this error in holder cleanup step, which happens during logout
109 ↗	(On Diff #45921)	Same as above / below, it's just passed deeper into call sites
152 ↗	(On Diff #45921)	This is a holder cleanup, it's already called during logout. If the CSAT is invalid here, server-side cleanup will take care of this.

Thanks for explaining!

This revision is now accepted and ready to land.Mon, Nov 25, 1:20 PM

Rebase

Harbormaster completed remote builds in B32852: Diff 46067.Tue, Nov 26, 6:38 AM

Closed by commit rCOMMf4e33a13ca08: [lib][keyserver] Handle invalid CSAT for multi-holder actions (authored by bartek). · Explain WhyFri, Nov 29, 5:03 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf4e33a13ca08: [lib][keyserver] Handle invalid CSAT for multi-holder actions.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

services/

5 lines

lib/

actions/

holder-actions.js

18 lines

handlers/

holders-handler.react.js

7 lines

push/

send-hooks.react.js

3 lines

utils/

blob-service.js

8 lines

Diff 46138

keyserver/src/services/blob.js

Loading...

lib/actions/holder-actions.js

Loading...

lib/handlers/holders-handler.react.js

Loading...

lib/push/send-hooks.react.js

Loading...

lib/utils/blob-service.js

Loading...