Page MenuHomePhabricator

[native] Move button expansion logic in ChatInputBar to function component
ClosedPublic

Authored by angelika on Nov 22 2024, 4:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 4:57 PM
Unknown Object (File)
Mon, Mar 3, 9:32 AM
Unknown Object (File)
Sun, Mar 2, 11:50 PM
Unknown Object (File)
Sun, Mar 2, 9:30 PM
Unknown Object (File)
Sat, Mar 1, 9:53 AM
Unknown Object (File)
Fri, Feb 28, 2:56 AM
Unknown Object (File)
Feb 18 2025, 1:10 PM
Unknown Object (File)
Feb 18 2025, 1:10 PM
Subscribers

Details

Summary
Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

  • focus the text input and verify the keyboard is up and the camera buttons are animated correctly
  • try to send the message, verify the send button is animated correctly
  • verify the text input can be unfocused and keyboard is hidden
  • verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
  • verify the edit mode works by editing a message
  • try to close the chat while editing a message - the alert should be shown
  • try to join a thread
  • try to select typed text

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added inline comments.
native/chat/chat-input-bar.react.js
319 ↗(On Diff #45950)

Looks like you could remove this from the class component's props at this point, but I suppose you'll do that in a later diff?

This revision is now accepted and ready to land.Nov 23 2024, 10:48 AM