Page MenuHomePhabricator

[native] Move join thread functions in ChatInputBar to function component
ClosedPublic

Authored by angelika on Nov 22 2024, 4:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 3:21 AM
Unknown Object (File)
Tue, Apr 1, 5:47 PM
Unknown Object (File)
Tue, Apr 1, 11:08 AM
Unknown Object (File)
Tue, Apr 1, 8:39 AM
Unknown Object (File)
Tue, Apr 1, 6:42 AM
Unknown Object (File)
Tue, Apr 1, 5:34 AM
Unknown Object (File)
Mon, Mar 31, 10:24 AM
Unknown Object (File)
Thu, Mar 27, 12:56 AM
Subscribers

Details

Summary
Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

  • focus the text input and verify the keyboard is up and the camera buttons are animated correctly
  • try to send the message, verify the send button is animated correctly
  • verify the text input can be unfocused and keyboard is hidden
  • verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
  • verify the edit mode works by editing a message
  • try to close the chat while editing a message - the alert should be shown
  • try to join a thread
  • try to select typed text

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added inline comments.
native/chat/chat-input-bar.react.js
1413 ↗(On Diff #45955)

I think it would be good to have the callJoinThread declaration next to this

This revision is now accepted and ready to land.Nov 24 2024, 6:33 PM