Page MenuHomePhabricator

[native] Migrate ChatInputBar component to Reanimated v2 API
Needs RevisionPublic

Authored by angelika on Fri, Nov 22, 4:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 1:38 PM
Unknown Object (File)
Fri, Nov 22, 1:38 PM
Unknown Object (File)
Fri, Nov 22, 1:36 PM
Subscribers

Details

Summary
Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

  • focus the text input and verify the keyboard is up and the camera buttons are animated correctly
  • try to send the message, verify the send button is animated correctly
  • verify the text input can be unfocused and keyboard is hidden
  • verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
  • verify the edit mode works by editing a message
  • try to close the chat while editing a message - the alert should be shown
  • try to join a thread
  • try to select typed text

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested changes to this revision.Mon, Nov 25, 9:02 AM

I haven't had a chance to review this yet, but I discussed it with @angelika in our 1:1 just now. In our discussion we realized that this diff changes some animation behavior, so I'm passing back to @angelika to document what changes she's made.

This revision now requires changes to proceed.Mon, Nov 25, 9:02 AM