Details
Details
Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:
- focus the text input and verify the keyboard is up and the camera buttons are animated correctly
- try to send the message, verify the send button is animated correctly
- verify the text input can be unfocused and keyboard is hidden
- verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
- verify the edit mode works by editing a message
- try to close the chat while editing a message - the alert should be shown
- try to join a thread
- try to select typed text
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/chat/chat-input-bar.react.js | ||
|---|---|---|
| 1391–1393 ↗ | (On Diff #45954) | I think it's messy to define this in the same useEffect as the other stuff. Why not implement a separate useEffect? |
Comment Actions
Removing from my queue
(In the future, you can hit "Plan Changes" after a rebase update to keep a diff with requested changes on your queue instead of sending it back to your reviewers' queue)