Page MenuHomePhabricator

[native] Move navigation related callbacks in ChatInputBar to function component
ClosedPublic

Authored by angelika on Nov 22 2024, 4:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 2:04 AM
Unknown Object (File)
Mon, Dec 16, 2:04 AM
Unknown Object (File)
Mon, Dec 16, 2:04 AM
Unknown Object (File)
Sat, Dec 14, 10:24 AM
Unknown Object (File)
Thu, Dec 5, 10:48 PM
Unknown Object (File)
Thu, Dec 5, 2:43 PM
Unknown Object (File)
Thu, Dec 5, 10:53 AM
Unknown Object (File)
Thu, Dec 5, 6:13 AM
Subscribers

Details

Summary
Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

  • focus the text input and verify the keyboard is up and the camera buttons are animated correctly
  • try to send the message, verify the send button is animated correctly
  • verify the text input can be unfocused and keyboard is hidden
  • verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
  • verify the edit mode works by editing a message
  • try to close the chat while editing a message - the alert should be shown
  • try to join a thread
  • try to select typed text

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added inline comments.
native/chat/chat-input-bar.react.js
1350–1358 ↗(On Diff #45953)

Would it make sense to define this right before unblockNavigation?

1404 ↗(On Diff #45953)

Nit: I think this has the same effect

This revision is now accepted and ready to land.Sun, Nov 24, 6:31 PM