Page MenuHomePhabricator
Differential D14115

[native] implement screen when connecting secondary device
ClosedPublic
Actions

Authored by kamil on Wed, Dec 11, 8:16 AM.
Tags
None
Referenced Files
F3518554: D14115.id46537.diff
Sun, Dec 22, 8:21 PM
Unknown Object (File)
Sat, Dec 21, 3:19 PM
Unknown Object (File)
Fri, Dec 20, 5:02 PM
Unknown Object (File)
Fri, Dec 20, 2:17 AM
Unknown Object (File)
Tue, Dec 17, 7:21 PM
Unknown Object (File)
Tue, Dec 17, 7:16 AM
Unknown Object (File)
Mon, Dec 16, 1:18 PM
Unknown Object (File)
Sat, Dec 14, 3:33 PM
View All 11 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM9d05d9a88292: [native] implement screen when connecting secondary device
Summary

ENG-9959.

Copy is taken from existing Alert.

This diff is just UI, navigating to it and logic is implemented later in the stack.

In ENG-9968 there is an example of how the flow looks like.

IMG_4787 (1).PNG (1×828 px, 51 KB)

Depends on D14114

Test Plan

Navigate to screen

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Dec 11, 8:16 AM
kamil held this revision as a draft.
kamil added a child revision: D14116: [native] navigate to proper screen after scanning QR code.
kamil edited the summary of this revision. (Show Details)Wed, Dec 11, 8:22 AM
kamil published this revision for review.Wed, Dec 11, 8:30 AM
kamil added inline comments.
native/account/qr-auth/qr-auth-context-provider.js
96–98 ↗(On Diff #46333)

Here we should navigate to the success screen, this will be added later in the stack

Harbormaster completed remote builds in B33015: Diff 46333.Wed, Dec 11, 9:58 AM
ashoat accepted this revision.Thu, Dec 12, 11:00 AM
ashoat added 1 blocking reviewer(s): tomek.

Would appreciate @tomek's help in reviewing the QRAuthContext part... it's hard for me to track the whole flow and where connectingInProgress should be set

native/navigation/route-names.js
360–362 ↗(On Diff #46333)

We usually define the params type in the file that has the component, and import it in this file

tomek accepted this revision.Fri, Dec 13, 6:15 AM
This revision is now accepted and ready to land.Fri, Dec 13, 6:15 AM
kamil updated this revision to Diff 46537.Tue, Dec 17, 4:36 AM

move params definition to /qr-auth/connect-secondary-device.react.js

Harbormaster completed remote builds in B33158: Diff 46537.Tue, Dec 17, 5:09 AM
Closed by commit rCOMM9d05d9a88292: [native] implement screen when connecting secondary device (authored by kamil). · Explain WhyTue, Dec 17, 7:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM9d05d9a88292: [native] implement screen when connecting secondary device.

Revision Contents
Changeset List

Diff 46537

View Options

native/account/qr-auth/connect-secondary-device.react.js

Loading...
View Options

native/account/qr-auth/qr-auth-context-provider.js

Loading...
View Options

native/account/qr-auth/qr-auth-context.js

Loading...
View Options

native/account/qr-auth/qr-auth-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...