Page MenuHomePhabricator

[native] implement screen when connecting secondary device
ClosedPublic

Authored by kamil on Wed, Dec 11, 8:16 AM.
Tags
None
Referenced Files
F3518554: D14115.id46537.diff
Sun, Dec 22, 8:21 PM
Unknown Object (File)
Sat, Dec 21, 3:19 PM
Unknown Object (File)
Fri, Dec 20, 5:02 PM
Unknown Object (File)
Fri, Dec 20, 2:17 AM
Unknown Object (File)
Tue, Dec 17, 7:21 PM
Unknown Object (File)
Tue, Dec 17, 7:16 AM
Unknown Object (File)
Mon, Dec 16, 1:18 PM
Unknown Object (File)
Sat, Dec 14, 3:33 PM
Subscribers
None

Details

Summary

ENG-9959.

Copy is taken from existing Alert.

This diff is just UI, navigating to it and logic is implemented later in the stack.

In ENG-9968 there is an example of how the flow looks like.

IMG_4787 (1).PNG (1×828 px, 51 KB)

Depends on D14114

Test Plan

Navigate to screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil published this revision for review.Wed, Dec 11, 8:30 AM
kamil added inline comments.
native/account/qr-auth/qr-auth-context-provider.js
96–98 ↗(On Diff #46333)

Here we should navigate to the success screen, this will be added later in the stack

ashoat added 1 blocking reviewer(s): tomek.

Would appreciate @tomek's help in reviewing the QRAuthContext part... it's hard for me to track the whole flow and where connectingInProgress should be set

native/navigation/route-names.js
360–362 ↗(On Diff #46333)

We usually define the params type in the file that has the component, and import it in this file

This revision is now accepted and ready to land.Fri, Dec 13, 6:15 AM

move params definition to /qr-auth/connect-secondary-device.react.js