Page MenuHomePhabricator
Differential D14467

[backup] Return keyserver device ID in latest backup info endpoint
ClosedPublic
Actions

Authored by bartek on Thu, Mar 20, 4:02 AM.
Tags
None
Referenced Files
F5083349: D14467.id47528.diff
Sat, Mar 29, 11:25 AM
F5080514: D14467.id47530.diff
Sat, Mar 29, 3:17 AM
F5077792: D14467.id47477.diff
Fri, Mar 28, 11:29 PM
F5076520: D14467.id.diff
Fri, Mar 28, 7:53 PM
Unknown Object (File)
Fri, Mar 28, 2:56 PM
Unknown Object (File)
Fri, Mar 28, 2:11 PM
Unknown Object (File)
Fri, Mar 28, 12:33 PM
Unknown Object (File)
Thu, Mar 27, 5:30 PM
View All 23 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMMbefb888d494e: [backup] Return keyserver device ID in latest backup info endpoint
Summary

Address server-side of ENG-10236. Implemented approach 2 from task comments.

Depends on D14466

Test Plan

Using Postman, called the endpoint for user with- and without keyserver. Verified that returned device ID matches my keyserver device ID.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Thu, Mar 20, 4:02 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Mar 20, 4:02 AM
bartek updated this revision to Diff 47478.Thu, Mar 20, 4:10 AM

Add missing reference

Harbormaster failed remote builds in B33774: Diff 47478!Thu, Mar 20, 4:22 AM
Harbormaster failed remote builds in B33773: Diff 47477!Thu, Mar 20, 4:28 AM
bartek published this revision for review.Sun, Mar 23, 11:51 PM
bartek added inline comments.
shared/comm-lib/src/backup/mod.rs
15 ↗(On Diff #47477)

I missed committing this

bartek added a child revision: D14489: [lib][native] Add keyserverDeviceID to LatestBackupInfo.Mon, Mar 24, 3:30 AM
kamil accepted this revision.Mon, Mar 24, 3:56 AM
kamil added inline comments.
services/backup/src/identity/mod.rs
59 ↗(On Diff #47478)

If this is easy I would add tests for it, in e.g. identity_integration_tests.rs

This revision is now accepted and ready to land.Mon, Mar 24, 3:56 AM
bartek added inline comments.Mon, Mar 24, 6:07 AM
services/backup/src/identity/mod.rs
59 ↗(On Diff #47478)

We have test_device_list_multifetch which tests this RPC call

bartek updated this revision to Diff 47527.Mon, Mar 24, 6:08 AM

Add serde rename directive

Harbormaster failed remote builds in B33816: Diff 47527!Mon, Mar 24, 6:20 AM
This revision was landed with ongoing or failed builds.Mon, Mar 24, 6:55 AM
Closed by commit rCOMMbefb888d494e: [backup] Return keyserver device ID in latest backup info endpoint (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMbefb888d494e: [backup] Return keyserver device ID in latest backup info endpoint.

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
3 lines
services/
backup/
src/
http/
handlers/
7 lines
identity/
52 lines
shared/
comm-lib/
src/
backup/
2 lines

Diff 47530

View Options

native/native_rust_library/src/backup.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Text, useWindowDimensions } from 'react-native'; import { View, Text, useWindowDimensions } from 'react-native';
import QRCode from 'react-native-qrcode-svg'; import QRCode from 'react-native-qrcode-svg';
import { useSecondaryDeviceQRAuthContext } from 'lib/components/secondary-device-qr-auth-context-provider.react.js'; import { useSecondaryDeviceQRAuthContext } from 'lib/components/secondary-device-qr-auth-context-provider.react.js';
import { qrCodeLinkURL } from 'lib/facts/links.js'; import { qrCodeLinkURL } from 'lib/facts/links.js';
import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js'; import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js';
import { getConfig } from 'lib/utils/config.js'; import { getConfig } from 'lib/utils/config.js';
import { usingRestoreFlow } from 'lib/utils/services-utils.js'; import { usingRestoreFlow } from 'lib/utils/services-utils.js';
import AuthButtonContainer from './registration/registration-button-container.react.js'; import AuthButtonContainer from './auth-components/auth-button-container.react.js';
import AuthContainer from './registration/registration-container.react.js'; import AuthContainer from './auth-components/auth-container.react.js';
import AuthContentContainer from './registration/registration-content-container.react.js'; import AuthContentContainer from './auth-components/auth-content-container.react.js';
import type { SignInNavigationProp } from './sign-in-navigator.react.js'; import type { SignInNavigationProp } from './sign-in-navigator.react.js';
import LinkButton from '../components/link-button.react.js'; import LinkButton from '../components/link-button.react.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { RestorePromptScreenRouteName } from '../navigation/route-names.js'; import { RestorePromptScreenRouteName } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
type QRCodeScreenProps = { type QRCodeScreenProps = {
+navigation: SignInNavigationProp<'QRCodeScreen'>, +navigation: SignInNavigationProp<'QRCodeScreen'>,
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

services/backup/src/http/handlers/backup.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Text, useWindowDimensions } from 'react-native'; import { View, Text, useWindowDimensions } from 'react-native';
import QRCode from 'react-native-qrcode-svg'; import QRCode from 'react-native-qrcode-svg';
import { useSecondaryDeviceQRAuthContext } from 'lib/components/secondary-device-qr-auth-context-provider.react.js'; import { useSecondaryDeviceQRAuthContext } from 'lib/components/secondary-device-qr-auth-context-provider.react.js';
import { qrCodeLinkURL } from 'lib/facts/links.js'; import { qrCodeLinkURL } from 'lib/facts/links.js';
import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js'; import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js';
import { getConfig } from 'lib/utils/config.js'; import { getConfig } from 'lib/utils/config.js';
import { usingRestoreFlow } from 'lib/utils/services-utils.js'; import { usingRestoreFlow } from 'lib/utils/services-utils.js';
import AuthButtonContainer from './registration/registration-button-container.react.js'; import AuthButtonContainer from './auth-components/auth-button-container.react.js';
import AuthContainer from './registration/registration-container.react.js'; import AuthContainer from './auth-components/auth-container.react.js';
import AuthContentContainer from './registration/registration-content-container.react.js'; import AuthContentContainer from './auth-components/auth-content-container.react.js';
import type { SignInNavigationProp } from './sign-in-navigator.react.js'; import type { SignInNavigationProp } from './sign-in-navigator.react.js';
import LinkButton from '../components/link-button.react.js'; import LinkButton from '../components/link-button.react.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { RestorePromptScreenRouteName } from '../navigation/route-names.js'; import { RestorePromptScreenRouteName } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
type QRCodeScreenProps = { type QRCodeScreenProps = {
+navigation: SignInNavigationProp<'QRCodeScreen'>, +navigation: SignInNavigationProp<'QRCodeScreen'>,
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

services/backup/src/identity/mod.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Text, useWindowDimensions } from 'react-native'; import { View, Text, useWindowDimensions } from 'react-native';
import QRCode from 'react-native-qrcode-svg'; import QRCode from 'react-native-qrcode-svg';
import { useSecondaryDeviceQRAuthContext } from 'lib/components/secondary-device-qr-auth-context-provider.react.js'; import { useSecondaryDeviceQRAuthContext } from 'lib/components/secondary-device-qr-auth-context-provider.react.js';
import { qrCodeLinkURL } from 'lib/facts/links.js'; import { qrCodeLinkURL } from 'lib/facts/links.js';
import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js'; import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js';
import { getConfig } from 'lib/utils/config.js'; import { getConfig } from 'lib/utils/config.js';
import { usingRestoreFlow } from 'lib/utils/services-utils.js'; import { usingRestoreFlow } from 'lib/utils/services-utils.js';
import AuthButtonContainer from './registration/registration-button-container.react.js'; import AuthButtonContainer from './auth-components/auth-button-container.react.js';
import AuthContainer from './registration/registration-container.react.js'; import AuthContainer from './auth-components/auth-container.react.js';
import AuthContentContainer from './registration/registration-content-container.react.js'; import AuthContentContainer from './auth-components/auth-content-container.react.js';
import type { SignInNavigationProp } from './sign-in-navigator.react.js'; import type { SignInNavigationProp } from './sign-in-navigator.react.js';
import LinkButton from '../components/link-button.react.js'; import LinkButton from '../components/link-button.react.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { RestorePromptScreenRouteName } from '../navigation/route-names.js'; import { RestorePromptScreenRouteName } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
type QRCodeScreenProps = { type QRCodeScreenProps = {
+navigation: SignInNavigationProp<'QRCodeScreen'>, +navigation: SignInNavigationProp<'QRCodeScreen'>,
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

shared/comm-lib/src/backup/mod.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Text, useWindowDimensions } from 'react-native'; import { View, Text, useWindowDimensions } from 'react-native';
import QRCode from 'react-native-qrcode-svg'; import QRCode from 'react-native-qrcode-svg';
import { useSecondaryDeviceQRAuthContext } from 'lib/components/secondary-device-qr-auth-context-provider.react.js'; import { useSecondaryDeviceQRAuthContext } from 'lib/components/secondary-device-qr-auth-context-provider.react.js';
import { qrCodeLinkURL } from 'lib/facts/links.js'; import { qrCodeLinkURL } from 'lib/facts/links.js';
import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js'; import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js';
import { getConfig } from 'lib/utils/config.js'; import { getConfig } from 'lib/utils/config.js';
import { usingRestoreFlow } from 'lib/utils/services-utils.js'; import { usingRestoreFlow } from 'lib/utils/services-utils.js';
import AuthButtonContainer from './registration/registration-button-container.react.js'; import AuthButtonContainer from './auth-components/auth-button-container.react.js';
import AuthContainer from './registration/registration-container.react.js'; import AuthContainer from './auth-components/auth-container.react.js';
import AuthContentContainer from './registration/registration-content-container.react.js'; import AuthContentContainer from './auth-components/auth-content-container.react.js';
import type { SignInNavigationProp } from './sign-in-navigator.react.js'; import type { SignInNavigationProp } from './sign-in-navigator.react.js';
import LinkButton from '../components/link-button.react.js'; import LinkButton from '../components/link-button.react.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { RestorePromptScreenRouteName } from '../navigation/route-names.js'; import { RestorePromptScreenRouteName } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
type QRCodeScreenProps = { type QRCodeScreenProps = {
+navigation: SignInNavigationProp<'QRCodeScreen'>, +navigation: SignInNavigationProp<'QRCodeScreen'>,
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines