[identity] Refactor devices data deletion to allow filtering
ClosedPublic
Actions

Authored by bartek on Tue, Mar 25, 6:52 AM.

Details

Reviewers

kamil

Commits

rCOMMca6dc08b6f22: [identity] Refactor devices data deletion to allow filtering

Summary

Part of ENG-10413.
Refactored function to delete device data from the identity-devices table.
Added option to exclude certain device IDs, and made it slightly more efficient by reducing number of iterator conversions.

Depends on D14499

Test Plan

Tested on staging along with the rest of the stack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Tue, Mar 25, 6:52 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Mar 25, 6:52 AM

bartek added a child revision: D14501: [identity] Skip keyserver during primary logout and restore.Tue, Mar 25, 7:01 AM

Harbormaster failed remote builds in B33824: Diff 47539!Tue, Mar 25, 7:13 AM

bartek published this revision for review.Tue, Mar 25, 7:44 AM

kamil accepted this revision.Tue, Mar 25, 11:49 AM

This revision is now accepted and ready to land.Tue, Mar 25, 11:49 AM

This revision was landed with ongoing or failed builds.Wed, Mar 26, 7:55 AM

Closed by commit rCOMMca6dc08b6f22: [identity] Refactor devices data deletion to allow filtering (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMca6dc08b6f22: [identity] Refactor devices data deletion to allow filtering.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

53 lines

Diff 47567

View Options

services/identity/src/database/device_list.rs

	locals {			locals {
	identity_service_image_tag = local.is_staging ? "0.22-staging" : "0.18"			identity_service_image_tag = local.is_staging ? "0.23-staging" : "0.18"
	identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"			identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"
	identity_service_container_name = "identity-server"			identity_service_container_name = "identity-server"

	# Port that the container is listening on			# Port that the container is listening on
	identity_service_container_grpc_port = 50054			identity_service_container_grpc_port = 50054
	identity_sc_port_name = "identity-service-ecs-grpc"			identity_sc_port_name = "identity-service-ecs-grpc"
	identity_sc_dns_name = "identity-service"			identity_sc_dns_name = "identity-service"

	▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines

[identity] Refactor devices data deletion to allow filteringClosedPublicActions