Tags

None

Referenced Files

	F5109501: D14499.id47559.diff
	Tue, Apr 1, 7:13 PM

	F5104147: D14499.id47559.diff
	Tue, Apr 1, 1:30 AM

	F5103999: D14499.id47566.diff
	Tue, Apr 1, 12:56 AM

	Unknown Object (File)
	Mon, Mar 31, 2:28 PM

	Unknown Object (File)
	Mon, Mar 31, 3:11 AM

	Unknown Object (File)
	Mon, Mar 31, 3:09 AM

	Unknown Object (File)
	Sat, Mar 29, 1:40 PM

	Unknown Object (File)
	Sat, Mar 29, 11:50 AM

View All 14 Files

Subscribers

ashoat

tomek

Details

Reviewers

kamil

Commits

rCOMMdf5ae533da28: [identity] Fix OTK removal in clean_up_devices_data

Summary

Fixed bug mentioned in ENG-10413.
Previously, OTKs were removed based on already-updated device list which didn't contain device IDs that were supposed to have OTKs removed. Now, we provide device IDs explicitly.

Depends on D14498

Test Plan

Tested on staging along with the rest of the stack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Tue, Mar 25, 6:50 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Mar 25, 6:50 AM

bartek added a child revision: D14500: [identity] Refactor devices data deletion to allow filtering.Tue, Mar 25, 6:52 AM

Harbormaster completed remote builds in B33823: Diff 47538.Tue, Mar 25, 7:15 AM

bartek published this revision for review.Tue, Mar 25, 7:43 AM

kamil accepted this revision.Tue, Mar 25, 11:45 AM

This revision is now accepted and ready to land.Tue, Mar 25, 11:45 AM

Fix typo

Harbormaster completed remote builds in B33841: Diff 47559.Wed, Mar 26, 4:06 AM

Closed by commit rCOMMdf5ae533da28: [identity] Fix OTK removal in clean_up_devices_data (authored by bartek). · Explain WhyWed, Mar 26, 7:55 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMdf5ae533da28: [identity] Fix OTK removal in clean_up_devices_data.

[identity] Fix OTK removal in clean_up_devices_data
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 47566

services/identity/src/database/device_list.rs

services/identity/src/database/one_time_keys.rs

[identity] Fix OTK removal in clean_up_devices_dataClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47566

services/identity/src/database/device_list.rs

services/identity/src/database/one_time_keys.rs

[identity] Fix OTK removal in clean_up_devices_data
ClosedPublic
Actions

Revision Contents
Changeset List