Page MenuHomePhabricator
Differential D14501

[identity] Skip keyserver during primary logout and restore
ClosedPublic
Actions

Authored by bartek on Tue, Mar 25, 7:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 7:39 PM
Unknown Object (File)
Wed, Apr 9, 4:18 PM
Unknown Object (File)
Sun, Apr 6, 3:09 PM
Unknown Object (File)
Sun, Apr 6, 1:40 PM
Unknown Object (File)
Sun, Apr 6, 1:13 PM
Unknown Object (File)
Sun, Apr 6, 12:07 PM
Unknown Object (File)
Sun, Apr 6, 10:09 AM
Unknown Object (File)
Fri, Apr 4, 10:25 PM
View All 29 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMM0a82eb871ff8: [identity] Skip keyserver during primary logout and restore
Summary

Address ENG-10233 and data deletion part of ENG-10239.
Updated primary logout and restore to skip keyserver (if present) during devices removal.

Depends on D14490, D14500

Test Plan

Tested on staging along with the rest of the stack. For keyserver owner:

  • Did primary device logout. Verified that keyserver device wasn't removed from DDB
  • Performed a restore. Keyserver wasn't removed.

For users not owning a keyserver, all old devices data is removed, leaving only singleton device lists.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Tue, Mar 25, 7:01 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Mar 25, 7:01 AM
Harbormaster completed remote builds in B33825: Diff 47540.Tue, Mar 25, 7:35 AM
bartek published this revision for review.Tue, Mar 25, 7:45 AM
kamil accepted this revision.Tue, Mar 25, 11:56 AM
kamil added inline comments.
services/identity/src/grpc_services/authenticated.rs
584–589 ↗(On Diff #47540)

I prefer this syntax but up to you

This revision is now accepted and ready to land.Tue, Mar 25, 11:56 AM
bartek updated this revision to Diff 47560.Wed, Mar 26, 3:48 AM

Use alternative syntax

Harbormaster completed remote builds in B33842: Diff 47560.Wed, Mar 26, 4:07 AM
Closed by commit rCOMM0a82eb871ff8: [identity] Skip keyserver during primary logout and restore (authored by bartek). · Explain WhyWed, Mar 26, 7:55 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM0a82eb871ff8: [identity] Skip keyserver during primary logout and restore.
bartek mentioned this in D14506: [lib][native] Keep keyserver in device list after primary logout.Thu, Mar 27, 2:24 AM
bartek mentioned this in rCOMMfc01ada1f576: [lib][native] Keep keyserver in device list after primary logout.Thu, Mar 27, 5:23 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
22 lines
grpc_services/
22 lines

Diff 47568

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...