[identity] Fix OTK removal in clean_up_devices_data
ClosedPublic
Actions

Authored by bartek on Tue, Mar 25, 6:50 AM.

Details

Reviewers

Commits

rCOMMdf5ae533da28: [identity] Fix OTK removal in clean_up_devices_data

Summary

Fixed bug mentioned in ENG-10413.
Previously, OTKs were removed based on already-updated device list which didn't contain device IDs that were supposed to have OTKs removed. Now, we provide device IDs explicitly.

Depends on D14498

Test Plan

Tested on staging along with the rest of the stack.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Tue, Mar 25, 6:50 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Mar 25, 6:50 AM

bartek added a child revision: D14500: [identity] Refactor devices data deletion to allow filtering.Tue, Mar 25, 6:52 AM

Harbormaster completed remote builds in B33823: Diff 47538.Tue, Mar 25, 7:15 AM

bartek published this revision for review.Tue, Mar 25, 7:43 AM

kamil accepted this revision.Tue, Mar 25, 11:45 AM

This revision is now accepted and ready to land.Tue, Mar 25, 11:45 AM

Fix typo

Harbormaster completed remote builds in B33841: Diff 47559.Wed, Mar 26, 4:06 AM

Closed by commit rCOMMdf5ae533da28: [identity] Fix OTK removal in clean_up_devices_data (authored by bartek). · Explain WhyWed, Mar 26, 7:55 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMdf5ae533da28: [identity] Fix OTK removal in clean_up_devices_data.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

9 lines

Diff 47538

View Options

services/identity/src/database/device_list.rs

	Show All 33 Lines
	function useCreateDesktopPushSubscription() {			function useCreateDesktopPushSubscription() {
	const dispatchActionPromise = useDispatchActionPromise();			const dispatchActionPromise = useDispatchActionPromise();
	const callSetDeviceToken = useSetDeviceTokenFanout();			const callSetDeviceToken = useSetDeviceTokenFanout();
	const staffCanSee = useStaffCanSee();			const staffCanSee = useStaffCanSee();

	React.useEffect(			React.useEffect(
	() =>			() =>
	electron?.onDeviceTokenRegistered?.((token: ?string) => {			electron?.onDeviceTokenRegistered?.((token: ?string) => {
	dispatchActionPromise(			void dispatchActionPromise(
	setDeviceTokenActionTypes,			setDeviceTokenActionTypes,
	callSetDeviceToken(token),			callSetDeviceToken(token),
	);			);
	}),			}),
	[callSetDeviceToken, dispatchActionPromise],			[callSetDeviceToken, dispatchActionPromise],
	);			);

	React.useEffect(() => {			React.useEffect(() => {
	▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines

[identity] Fix OTK removal in clean_up_devices_dataClosedPublicActions