Page MenuHomePhabricator
Differential D14519

[SQLite] copy tables during restore instead of replacing entire database
ClosedPublic
Actions

Authored by kamil on Thu, Apr 3, 2:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 2:52 PM
Unknown Object (File)
Sat, Apr 19, 3:59 PM
Unknown Object (File)
Sat, Apr 19, 2:06 PM
Unknown Object (File)
Fri, Apr 18, 5:52 AM
Unknown Object (File)
Wed, Apr 16, 8:54 PM
Unknown Object (File)
Wed, Apr 16, 1:54 AM
Unknown Object (File)
Mon, Apr 14, 9:21 PM
Unknown Object (File)
Mon, Apr 14, 7:13 PM
View All 16 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMbb6cb42b2e5f: [SQLite] copy tables during restore instead of replacing entire database
Summary

ENG-10489.

The Online Backup API completely erases data in the existing (target database). This causes the user to be logged out because olm_persist_account is not included in the backup, which means when we download and restore, the Olm account is completely erased, which causes CSAT invalidation.

Depends on D14518

Test Plan

Existing tables (e.g. olm_persist_account) are not overwritten during restore

Diff Detail

Repository
rCOMM Comm
Branch
backup-publish
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Thu, Apr 3, 2:45 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 3, 2:45 AM
kamil retitled this revision from [SQLite] copy tables during restore instead of replacing entire database to [SQLite] copy tables during restore instead of replacing entire database.Thu, Apr 3, 2:46 AM
Harbormaster completed remote builds in B33874: Diff 47624.Thu, Apr 3, 3:02 AM
kamil published this revision for review.Thu, Apr 3, 3:13 AM
bartek accepted this revision.Thu, Apr 3, 3:50 AM
bartek mentioned this in D14517: [SQLite] implement method to copy table between databases.
This revision is now accepted and ready to land.Thu, Apr 3, 3:51 AM
kamil added a child revision: D14528: [lib][native] introduce `fullBackupSupport` flag.Thu, Apr 3, 4:02 AM
kamil updated this revision to Diff 47676.Mon, Apr 7, 3:02 AM

rebase before landing

Harbormaster completed remote builds in B33918: Diff 47676.Mon, Apr 7, 3:20 AM
Closed by commit rCOMMbb6cb42b2e5f: [SQLite] copy tables during restore instead of replacing entire database (authored by kamil). · Explain WhyMon, Apr 7, 3:30 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMbb6cb42b2e5f: [SQLite] copy tables during restore instead of replacing entire database.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
30 lines
web/
shared-worker/
_generated/

Diff 47624

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

web/shared-worker/_generated/comm_query_executor.wasm

  • This file was deleted.
This file was completely deleted. Show File Contents