Page MenuHomePhabricator
Differential D14525

[lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI
ClosedPublic
Actions

Authored by kamil on Thu, Apr 3, 3:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 6:09 AM
Unknown Object (File)
Fri, Apr 18, 8:31 PM
Unknown Object (File)
Fri, Apr 18, 8:10 AM
Unknown Object (File)
Thu, Apr 17, 9:14 PM
Unknown Object (File)
Thu, Apr 17, 1:25 PM
Unknown Object (File)
Wed, Apr 16, 9:42 PM
Unknown Object (File)
Mon, Apr 14, 9:16 PM
Unknown Object (File)
Mon, Apr 14, 7:52 PM
View All 25 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMa373e93f8f0b: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI
Summary

ENG-10473

We're now able to call it from /lib and we have a consistent approach.

Depends on D14524

Test Plan

Close and open web/native app to make sure it still works

Diff Detail

Repository
rCOMM Comm
Branch
backup-publish
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Thu, Apr 3, 3:36 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 3, 3:36 AM
kamil edited the summary of this revision. (Show Details)Thu, Apr 3, 3:38 AM
Harbormaster completed remote builds in B33880: Diff 47630.Thu, Apr 3, 3:53 AM
kamil published this revision for review.Thu, Apr 3, 3:53 AM
kamil added inline comments.
native/database/store.js
66

This file is copy-pasted, the only change is this line. Previously, we had a bug because of passing communities - I have no idea why Flow failed to catch it

web/redux/initial-state-gate.js
73

As you can see in store.js, on web this was hardcoded to null

kamil added a child revision: D14528: [lib][native] introduce `fullBackupSupport` flag.Thu, Apr 3, 4:02 AM
bartek accepted this revision.Thu, Apr 3, 4:42 AM
This revision is now accepted and ready to land.Thu, Apr 3, 4:42 AM
kamil updated this revision to Diff 47685.Mon, Apr 7, 3:39 AM

rebase

Harbormaster completed remote builds in B33920: Diff 47685.Mon, Apr 7, 3:57 AM
Closed by commit rCOMMa373e93f8f0b: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI (authored by kamil). · Explain WhyMon, Apr 7, 4:09 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa373e93f8f0b: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI.

Revision Contents
Changeset List

PathSize
lib/
types/
3 lines
utils/
__mocks__/
1 line
native/
data/
74 lines
database/
2 lines
76 lines
web/
database/
3 lines
database/
shared-worker/
utils/
10 lines
redux/
6 lines
shared-worker/
utils/

Diff 47630

View Options

lib/types/sqlite-types.js

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

lib/utils/__mocks__/config.js

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

native/data/sqlite-data-handler.js

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

native/database/sqlite-api.js

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

native/database/store.js

Loading...
View Options

web/database/sqlite-api.js

Loading...
View Options

web/database/store.js

Loading...
View Options

web/redux/initial-state-gate.js

Loading...
View Options

web/shared-worker/utils/store.js

Loading...