Paths

Table of Contentst

-
native/account/
-
account/
-
restore.js

Differential D14533

[lib] attempt restoring User Data after restoring primary device
ClosedPublic
Actions

Authored by kamil on Thu, Apr 3, 5:00 AM.

Tags

None

Referenced Files

	F6186659: D14533.id47695.diff
	Wed, Apr 23, 11:13 AM

	F6170951: D14533.id47701.diff
	Wed, Apr 23, 2:08 AM

	Unknown Object (File)
	Sun, Apr 20, 12:33 PM

	Unknown Object (File)
	Fri, Apr 18, 4:22 PM

	Unknown Object (File)
	Fri, Apr 18, 6:20 AM

	Unknown Object (File)
	Thu, Apr 17, 2:20 PM

	Unknown Object (File)
	Mon, Apr 14, 11:10 PM

	Unknown Object (File)
	Mon, Apr 14, 10:56 AM

View All 27 Files

Subscribers

Details

Reviewers

Commits

rCOMM935209b41610: [lib] attempt restoring User Data after restoring primary device

Summary

This is optional, just to start testing this.

Depends on D14532

Test Plan

Flip fullBackupSupport, delete app, install and restore - all thick threads are there

Diff Detail

Repository

Branch

backup-publish

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Apr 3, 5:00 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 3, 5:00 AM

kamil published this revision for review.Thu, Apr 3, 5:02 AM

kamil added inline comments.

native/account/restore.js
183	Looks like code duplication with D14532, but trying to implement one method makes it less readable
193	we should so it this way as this is the source of truth for now, but wondering about renaming this because this might be confusing

bartek accepted this revision.Thu, Apr 3, 5:06 AM

bartek added inline comments.

native/account/restore.js
193	Agree, but I don't have any ideas for a better name

This revision is now accepted and ready to land.Thu, Apr 3, 5:06 AM

Harbormaster completed remote builds in B33888: Diff 47638.Thu, Apr 3, 5:18 AM

rebase before landing

Harbormaster completed remote builds in B33923: Diff 47695.Mon, Apr 7, 4:42 AM

Closed by commit rCOMM935209b41610: [lib] attempt restoring User Data after restoring primary device (authored by kamil). · Explain WhyMon, Apr 7, 4:46 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM935209b41610: [lib] attempt restoring User Data after restoring primary device.

Revision Contents
Changeset List

Path

Size

native/

account/

52 lines

Diff 47638

native/account/restore.js

Loading...