Page MenuHomePhabricator
Differential D3179

[services] Blob - Fix logic for primary key
ClosedPublic
Actions

Authored by • karol on Feb 11 2022, 3:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 3:47 PM
Unknown Object (File)
Wed, Nov 20, 4:29 PM
Unknown Object (File)
Fri, Nov 8, 10:38 PM
Unknown Object (File)
Tue, Nov 5, 6:42 PM
Unknown Object (File)
Thu, Oct 31, 9:32 PM
Unknown Object (File)
Oct 13 2024, 6:09 PM
Unknown Object (File)
Oct 13 2024, 6:09 PM
Unknown Object (File)
Oct 13 2024, 6:08 PM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
varun
ashoat
• jim
Commits
rCOMM4823d46d6df2: [services] Blob - Fix logic for primary key
Summary

We want to apply the changes from D3177 to all services.

I'm not sure what's the state of the tunnelbroker service so I created a task for it for now https://linear.app/comm/issue/ENG-728/fix-primary-key-logic-for-tunnelbroker

Depends on D3178

Test Plan
cd services
yarn test-blob-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Feb 11 2022, 3:43 AM
Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptFeb 11 2022, 3:43 AM
• karol edited the summary of this revision. (Show Details)Feb 11 2022, 3:53 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, varun.
• karol added a parent revision: D3178: [services] Backup - Reuse remove logic.
Harbormaster completed remote builds in B6747: Diff 9564.Feb 11 2022, 4:04 AM
• karol requested review of this revision.Feb 11 2022, 4:04 AM
tomek requested changes to this revision.Feb 11 2022, 7:56 AM

The comments I added in previous diffs in this stack also apply here, so I'll request changes

This revision now requires changes to proceed.Feb 11 2022, 7:56 AM
• karol mentioned this in D3175: [services] Backup - Add DB operations for Logs.Feb 14 2022, 2:51 AM
• karol added a comment.Feb 14 2022, 5:31 AM

I'm going to wait for a review for D3177 D3178 and apply changes here accordingly then.

• karol added a child revision: D3198: [services] Move folly from Blob to Backup base.Feb 15 2022, 5:21 AM
• karol updated this revision to Diff 9712.Feb 16 2022, 2:02 AM

update

Harbormaster completed remote builds in B6864: Diff 9712.Feb 16 2022, 2:07 AM
tomek accepted this revision.Feb 16 2022, 5:25 AM
This revision is now accepted and ready to land.Feb 16 2022, 5:25 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 16 2022, 5:25 AM
Herald added a subscriber: • benschac. · View Herald Transcript
This revision now requires review to proceed.Feb 16 2022, 5:25 AM
• max accepted this revision.Feb 16 2022, 4:58 PM
ashoat accepted this revision.Feb 21 2022, 11:53 PM
ashoat added a reviewer: • jim.
This revision is now accepted and ready to land.Feb 21 2022, 11:53 PM
Closed by commit rCOMM4823d46d6df2: [services] Blob - Fix logic for primary key (authored by • karol). · Explain WhyMar 4 2022, 4:06 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM4823d46d6df2: [services] Blob - Fix logic for primary key.

Revision Contents
Changeset List

PathSize
services/
blob/
docker-server/
contents/
server/
src/
DatabaseEntities/
3 lines
8 lines
25 lines
4 lines
8 lines
2 lines
22 lines

Diff 9712

View Options

services/blob/docker-server/contents/server/src/DatabaseEntities/BlobItem.h

Loading...
View Options

services/blob/docker-server/contents/server/src/DatabaseEntities/BlobItem.cpp

Loading...
View Options

services/blob/docker-server/contents/server/src/DatabaseEntities/Item.h

Loading...
View Options

services/blob/docker-server/contents/server/src/DatabaseEntities/ReverseIndexItem.h

Loading...
View Options

services/blob/docker-server/contents/server/src/DatabaseEntities/ReverseIndexItem.cpp

Loading...
View Options

services/blob/docker-server/contents/server/src/DatabaseManager.h

Loading...
View Options

services/blob/docker-server/contents/server/src/DatabaseManager.cpp

Loading...