[web] Render calendar navigation tab conditionally
ClosedPublic
Actions

Authored by • jacek on Feb 24 2022, 1:14 AM.

Details

Reviewers

tomek
ashoat
• benschac
atul

Commits

rCOMMfc0ded18dbea: [web] Render calendar navigation tab conditionally

Summary

Render calendar tab only if it is enabled - like in mobile app. By default it is enabled and the setting is not persisted after page refresh yet.

Test Plan

After introducing apps page (next diff), run web app and switch the calendar in Apps page. The navigation link to calendar should appear only if calendar enabled.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Feb 24 2022, 1:14 AM

Herald added subscribers: • karol, atul, • adrian, ashoat. · View Herald TranscriptFeb 24 2022, 1:14 AM

• jacek added a parent revision: D3265: [web] Introduce navigation for enabled apps tab.Feb 24 2022, 1:15 AM

• jacek added a child revision: D3266: [web] Introduce Apps page.

Harbormaster completed remote builds in B7006: Diff 9879.Feb 24 2022, 1:19 AM

• jacek requested review of this revision.Feb 24 2022, 1:19 AM

tomek requested changes to this revision.Feb 24 2022, 3:28 AM

tomek added inline comments.

web/sidebar/app-switcher.react.js
116 ↗	(On Diff #9879)	Is `classNames` function memoized? If it isn't, then `calendarNavClasses` value will be different in every render and this whole memoization is completely useless. To fix the issue we should either remove `React.useMemo` and not memoize this component or move `calendarNavClasses` inside the memo. It looks like the component is really simple so memoizing it is not necessary, but it's up to you.