Paths

Table of Contentst

Differential D3316

[web] [fix] chat tab icon alignment and spacing
ClosedPublic
Actions

Authored by • benschac on Mar 1 2022, 2:19 PM.

Tags

None

Referenced Files

	F3300622: D3316.diff
	Sun, Nov 17, 8:25 PM

	Unknown Object (File)
	Thu, Nov 7, 2:24 PM

	Unknown Object (File)
	Sun, Nov 3, 6:03 PM

	Unknown Object (File)
	Sun, Nov 3, 6:03 PM

	Unknown Object (File)
	Sun, Nov 3, 6:02 PM

	Unknown Object (File)
	Sun, Nov 3, 6:02 PM

	Unknown Object (File)
	Sun, Nov 3, 6:02 PM

	Unknown Object (File)
	Sun, Nov 3, 6:02 PM

Subscribers

Details

Reviewers

atul
ashoat

Commits

rCOMMa76be33cbe9d: [web] [fix] chat tab icon alignment and spacing

Summary

Align the chat tabs per the design. After re-sizing our icons, some of our icon layout css needed to be updated/fixed to match our design.

Image 2022-03-01 at 5.03.08 PM.jpg (1×1 px, 116 KB)

Image 2022-03-01 at 5.07.14 PM.jpg (1×1 px, 121 KB)

Image 2022-03-01 at 5.20.04 PM.jpg (1×2 px, 296 KB)

Test Plan

Make sure chat tabs visually match the design.

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/?node-id=1170%3A77104

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 1 2022, 2:19 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 1 2022, 2:19 PM

• benschac edited the summary of this revision. (Show Details)Mar 1 2022, 2:20 PM

• benschac edited the test plan for this revision. (Show Details)

• benschac added a parent revision: D3300: [web] fix input icons to be the correct size.

Harbormaster completed remote builds in B7098: Diff 10005.Mar 1 2022, 2:24 PM

• benschac requested review of this revision.Mar 1 2022, 2:24 PM

• benschac added a child revision: D3318: [web] [refactor] css thread tab css logic.Mar 1 2022, 4:05 PM

• benschac removed a child revision: D3318: [web] [refactor] css thread tab css logic.

• benschac added a child revision: D3318: [web] [refactor] css thread tab css logic.

Looks good, but think we can remove the span?

web/chat/chat-thread-tab.react.js
26 ↗	(On Diff #10005)	Do we still need this `span`? It seems like it was previously being styled, but now it's not? Feel free to re-request review if I'm missing something!

This revision now requires changes to proceed.Mar 3 2022, 8:44 AM

remove span, use p tag

web/chat/chat-thread-tab.react.js
26 ↗	(On Diff #10005)	updated, but added a <p> tag. I still think it's important to have some semantic html when there's text.

remove p

• benschac added inline comments.Mar 3 2022, 9:22 AM

web/chat/chat-thread-tab.react.js
26 ↗	(On Diff #10005)	nvm, i think its fine.

Harbormaster completed remote builds in B7135: Diff 10046.Mar 3 2022, 9:23 AM

Harbormaster completed remote builds in B7136: Diff 10047.Mar 3 2022, 9:28 AM

atul accepted this revision.Mar 3 2022, 11:18 AM

This revision is now accepted and ready to land.Mar 3 2022, 11:18 AM

atul added a reviewer: ashoat.Mar 3 2022, 11:18 AM

This revision now requires review to proceed.Mar 3 2022, 11:18 AM

ashoat accepted this revision.Mar 3 2022, 10:24 PM

This revision is now accepted and ready to land.Mar 3 2022, 10:24 PM

Closed by commit rCOMMa76be33cbe9d: [web] [fix] chat tab icon alignment and spacing (authored by • benschac). · Explain WhyMar 9 2022, 10:43 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMa76be33cbe9d: [web] [fix] chat tab icon alignment and spacing.

Revision Contents
Changeset List

Path

Size

web/

chat/

8 lines

chat-thread-tab.react.js

7 lines

Diff 10046

web/chat/chat-tabs.css

Loading...

web/chat/chat-thread-tab.react.js

Loading...