Details
Details
- Reviewers
• benschac atul • jacek - Commits
- rCOMMadc557bce798: [web] Export navigation tab types
Just check if opening chat and calendar still works
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This makes sense. Curious if we should follow a similar pattern that we have in native: https://github.com/CommE2E/comm/blob/master/lib/types/account-types.js
This _seems_ similar but also I'm cautious to say one-way-or-another because we don't use the correct (documented) routing system of react-router.
Comment Actions
What do you mean by similar pattern? Are you suggesting that we should put these in lib and use on both native and web? If that's the case, I'm not sure it is a good idea, because it is likely that our navigation structure will be different on different platforms. (usually native experiences consist of more screens because there's less place for the content)