Differential D3346
[web] add style prop to icon component Authored by • benschac on Mar 4 2022, 11:30 AM. Tags None Referenced Files
Details
we need a style prop to override inline styles the component gives us as defaults. This is a part of the API, I just never added it to the prop types initially. style prop in icomoon component: https://github.com/aykutkardas/react-icomoon/blob/master/src/index.tsx#L71 We shouldn't have any type errors using the style prop, and the styles in the style prop should work as expected.
Diff Detail
Event TimelineComment Actions This looks right to me... adding @ashoat as blocking reviewer since flow/I don't have much experience with the $Shape utility Comment Actions This is a cool find – I've never actually encountered CSSStyleDeclaration before. It took me some time to figure out if $Shape is necessary here. I saw CSSStyleDeclaration show up in the Flow lib, but I couldn't find any usage of $Shape<CSSStyleDeclaration>. I played around with it myself to confirm that $Shape was necessary, but for next time this is the kind of case where the diff author has the opportunity to save both reviewers a lot of time if you preemptively explain things that might be confusing. |