Depends on D3248
Put operation in the blob service refactored from sync to async api.
Differential D3415
[services][draft] Blob refactor to async API - Put • karol on Mar 14 2022, 7:19 AM. Authored by Tags None Referenced Files
Subscribers
Details
Diff Detail
Event TimelineComment Actions This code is really hard to read. The logic there is a dense complicated block of code, which would take a lot of time for anyone to read and understand. Could you spend some time refactoring it into e.g. functions (with descriptive names and clearly defined scope)? Or at least, think through this code, check which parts might be confusing and add long comments explaining what's going on. I can see that there's a draft label here. I guess we've agreed that we should use drafts only for arch review... but I might be wrong. Nevertheless, what's the difference here between draft and non-draft? Comment Actions Abandoning, I'm going to put up a new stack for this which will be hopefully easier to review. |