[lib] Create common logic for filtering available thread members actions
ClosedPublic
Actions

Authored by • jacek on Mar 22 2022, 10:39 AM.

Details

Reviewers

tomek

Commits

rCOMM8115a97a7eae: [lib] Create common logic for filtering available thread members actions

Summary

Moved logic responsible for filtering menu items in thread members panel into shared function between mobile and web.
No logic changes has been made in the shared function itself.

Test Plan

In web app, action menu in members modal contains the same elements as before. In mobile app, in thread settings, the same members options are avaliable.

Diff Detail

Repository

rCOMM Comm

Branch

jacek/members-8

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Mar 22 2022, 10:39 AM

Herald added subscribers: • benschac, • karol, atul and 2 others. · View Herald TranscriptMar 22 2022, 10:39 AM

• jacek added a parent revision: D3384: [web] Introduce `MembersModal`.Mar 22 2022, 10:40 AM

Harbormaster completed remote builds in B7530: Diff 10598.Mar 22 2022, 10:44 AM

• jacek requested review of this revision.Mar 22 2022, 10:44 AM

tomek accepted this revision.Mar 23 2022, 5:12 AM

tomek added inline comments.

lib/shared/thread-utils.js
1327 ↗	(On Diff #10598)	Can we use less general type (an enum)?
1347 ↗	(On Diff #10598)
native/chat/settings/thread-settings-member.react.js
98 ↗	(On Diff #10598)	In the new function we have one more condition here: `threadHasAdminRole(threadInfo)` - but this probably should be here from the beginning