Page MenuHomePhabricator
Differential D3668

[web] Remove `Modal`s usused style
ClosedPublic
Actions

Authored by • jacek on Apr 8 2022, 4:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 7:34 AM
Unknown Object (File)
Thu, Mar 6, 5:41 AM
Unknown Object (File)
Wed, Mar 5, 2:42 PM
Unknown Object (File)
Feb 18 2025, 10:25 AM
Unknown Object (File)
Feb 15 2025, 3:46 AM
Unknown Object (File)
Feb 13 2025, 8:50 AM
Unknown Object (File)
Feb 9 2025, 6:42 PM
Unknown Object (File)
Feb 7 2025, 4:21 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
tomek
atul
• benschac
Commits
rCOMM3274d77df84a: [web] Remove `Modal`s usused style
Summary

The style has not been used anywhere in the project

Test Plan

Nothing changes in project

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jacek created this revision.Apr 8 2022, 4:25 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 8 2022, 4:25 AM
Harbormaster completed remote builds in B8020: Diff 11225.Apr 8 2022, 4:33 AM
• jacek requested review of this revision.Apr 8 2022, 4:33 AM
• jacek added a child revision: D3669: [web] Redesign `Modal` to match Figma.Apr 8 2022, 6:01 AM
• jacek added reviewers: tomek, atul, • benschac.Apr 8 2022, 6:06 AM
atul accepted this revision.Apr 8 2022, 10:43 AM

Looks good!

(did a quick search of intro-modal, intro_modal, and introModal in the codebase just in case, and found no occurrences)

This revision is now accepted and ready to land.Apr 8 2022, 10:43 AM
• jacek updated this revision to Diff 11466.Apr 14 2022, 3:09 AM

rebase

Harbormaster completed remote builds in B8195: Diff 11466.Apr 14 2022, 3:14 AM
• jacek updated this revision to Diff 11878.Apr 25 2022, 10:27 AM

rebase

Harbormaster completed remote builds in B8519: Diff 11878.Apr 25 2022, 10:39 AM
• jacek updated this revision to Diff 11923.Apr 26 2022, 8:33 AM

rebase

Harbormaster completed remote builds in B8554: Diff 11923.Apr 26 2022, 8:46 AM
Closed by commit rCOMM3274d77df84a: [web] Remove `Modal`s usused style (authored by • jacek). · Explain WhyApr 26 2022, 9:09 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM3274d77df84a: [web] Remove `Modal`s usused style.

Revision Contents
Changeset List

PathSize
web/
modals/
12 lines

Diff 11934

View Options

web/modals/modal.css

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { View, Text, TouchableOpacity } from 'react-native'; import { View, Text, TouchableOpacity } from 'react-native';
import { useSafeAreaInsets } from 'react-native-safe-area-context'; import { useSafeAreaInsets } from 'react-native-safe-area-context';
import { relationshipBlockedInEitherDirection } from 'lib/shared/relationship-utils.js'; import { relationshipBlockedInEitherDirection } from 'lib/shared/relationship-utils.js';
import { useUserProfileThreadInfo } from 'lib/shared/thread-utils.js'; import { useUserProfileThreadInfo } from 'lib/shared/thread-utils.js';
import { stringForUserExplicit } from 'lib/shared/user-utils.js'; import { stringForUserExplicit } from 'lib/shared/user-utils.js';
import type { UserInfo } from 'lib/types/user-types'; import type { UserInfo } from 'lib/types/user-types';
import sleep from 'lib/utils/sleep.js'; import sleep from 'lib/utils/sleep.js';
import {
userProfileUserInfoContainerHeight,
userProfileBottomPadding,
userProfileMenuButtonHeight,
userProfileActionButtonHeight,
} from './user-profile-constants.js';
import UserProfileMessageButton from './user-profile-message-button.react.js'; import UserProfileMessageButton from './user-profile-message-button.react.js';
import UserProfileRelationshipButton from './user-profile-relationship-button.react.js'; import UserProfileRelationshipButton from './user-profile-relationship-button.react.js';
import UserAvatar from '../avatars/user-avatar.react.js'; import UserAvatar from '../avatars/user-avatar.react.js';
import { BottomSheetContext } from '../bottom-sheet/bottom-sheet-provider.react.js'; import { BottomSheetContext } from '../bottom-sheet/bottom-sheet-provider.react.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
Show All 18 Linesfunction UserProfile(props: Props): React.Node {
const bottomSheetContext = React.useContext(BottomSheetContext); const bottomSheetContext = React.useContext(BottomSheetContext);
invariant(bottomSheetContext, 'bottomSheetContext should be set'); invariant(bottomSheetContext, 'bottomSheetContext should be set');
const { setContentHeight } = bottomSheetContext; const { setContentHeight } = bottomSheetContext;
const insets = useSafeAreaInsets(); const insets = useSafeAreaInsets();
React.useLayoutEffect(() => { React.useLayoutEffect(() => {
const userInfoContainerHeight = 90; let height =
const bottomPadding = 40; insets.bottom +
userProfileUserInfoContainerHeight +
let height = insets.bottom + userInfoContainerHeight + bottomPadding; userProfileBottomPadding;
if (userProfileThreadInfo) { if (userProfileThreadInfo) {
const menuButtonHeight = 24; height += userProfileMenuButtonHeight;
height += menuButtonHeight;
} }
if ( if (
userProfileThreadInfo && userProfileThreadInfo &&
!relationshipBlockedInEitherDirection(userInfo?.relationshipStatus) !relationshipBlockedInEitherDirection(userInfo?.relationshipStatus)
) { ) {
const messageButtonHeight = 54; // message button height + relationship button height
height += messageButtonHeight + userProfileRelationshipButtonHeight; height +=
userProfileActionButtonHeight + userProfileRelationshipButtonHeight;
} }
setContentHeight(height); setContentHeight(height);
}, [ }, [
insets.bottom, insets.bottom,
setContentHeight, setContentHeight,
userInfo?.relationshipStatus, userInfo?.relationshipStatus,
userProfileRelationshipButtonHeight, userProfileRelationshipButtonHeight,
▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines