Page MenuHomePhabricator
Differential D3668

[web] Remove `Modal`s usused style
ClosedPublic
Actions

Authored by • jacek on Apr 8 2022, 4:25 AM.
Tags
None
Referenced Files
F5931214: D3668.id11934.diff
Fri, Apr 18, 4:15 AM
F5929685: D3668.id11466.diff
Fri, Apr 18, 2:58 AM
Unknown Object (File)
Fri, Apr 18, 12:15 AM
Unknown Object (File)
Fri, Apr 18, 12:08 AM
Unknown Object (File)
Thu, Apr 17, 11:35 PM
Unknown Object (File)
Thu, Apr 17, 8:25 PM
Unknown Object (File)
Thu, Apr 17, 10:08 AM
Unknown Object (File)
Tue, Apr 8, 6:31 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
tomek
atul
• benschac
Commits
rCOMM3274d77df84a: [web] Remove `Modal`s usused style
Summary

The style has not been used anywhere in the project

Test Plan

Nothing changes in project

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jacek created this revision.Apr 8 2022, 4:25 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 8 2022, 4:25 AM
Harbormaster completed remote builds in B8020: Diff 11225.Apr 8 2022, 4:33 AM
• jacek requested review of this revision.Apr 8 2022, 4:33 AM
• jacek added a child revision: D3669: [web] Redesign `Modal` to match Figma.Apr 8 2022, 6:01 AM
• jacek added reviewers: tomek, atul, • benschac.Apr 8 2022, 6:06 AM
atul accepted this revision.Apr 8 2022, 10:43 AM

Looks good!

(did a quick search of intro-modal, intro_modal, and introModal in the codebase just in case, and found no occurrences)

This revision is now accepted and ready to land.Apr 8 2022, 10:43 AM
• jacek updated this revision to Diff 11466.Apr 14 2022, 3:09 AM

rebase

Harbormaster completed remote builds in B8195: Diff 11466.Apr 14 2022, 3:14 AM
• jacek updated this revision to Diff 11878.Apr 25 2022, 10:27 AM

rebase

Harbormaster completed remote builds in B8519: Diff 11878.Apr 25 2022, 10:39 AM
• jacek updated this revision to Diff 11923.Apr 26 2022, 8:33 AM

rebase

Harbormaster completed remote builds in B8554: Diff 11923.Apr 26 2022, 8:46 AM
Closed by commit rCOMM3274d77df84a: [web] Remove `Modal`s usused style (authored by • jacek). · Explain WhyApr 26 2022, 9:09 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM3274d77df84a: [web] Remove `Modal`s usused style.

Revision Contents
Changeset List

PathSize
web/
modals/
12 lines

Diff 11934

View Options

web/modals/modal.css

#include "CommCoreModule.h" #include "CommCoreModule.h"
#include "../CryptoTools/DeviceID.h" #include "../CryptoTools/DeviceID.h"
#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h" #include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"
#include "BaseDataStore.h" #include "BaseDataStore.h"
#include "DatabaseManager.h" #include "DatabaseManager.h"
#include "InternalModules/GlobalDBSingleton.h" #include "InternalModules/GlobalDBSingleton.h"
#include "InternalModules/RustPromiseManager.h"
#include "NativeModuleUtils.h" #include "NativeModuleUtils.h"
#include "TerminateApp.h" #include "TerminateApp.h"
#include "lib.rs.h"
#include <ReactCommon/TurboModuleUtils.h> #include <ReactCommon/TurboModuleUtils.h>
#include <folly/dynamic.h> #include <folly/dynamic.h>
#include <folly/json.h> #include <folly/json.h>
#include <future> #include <future>
namespace comm { namespace comm {
▲ Show 20 Lines • Show All 782 Lines • ▼ Show 20 Lines
bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) { bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {
return DatabaseManager::checkIfDatabaseNeedsDeletion(); return DatabaseManager::checkIfDatabaseNeedsDeletion();
} }
void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) { void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {
DatabaseManager::reportDBOperationsFailure(); DatabaseManager::reportDBOperationsFailure();
} }
jsi::Value CommCoreModule::generateNonce(jsi::Runtime &rt) {
return createPromiseAsJSIValue(
rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityGenerateNonce(currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
jsi::Value CommCoreModule::registerUser(
jsi::Runtime &rt,
jsi::String username,
jsi::String password,
jsi::String keyPayload,
jsi::String keyPayloadSignature,
jsi::String contentPrekey,
jsi::String contentPrekeySignature,
jsi::String notifPrekey,
jsi::String notifPrekeySignature,
jsi::Array contentOneTimeKeys,
jsi::Array notifOneTimeKeys) {
return createPromiseAsJSIValue(
rt,
[this,
&username,
&password,
&keyPayload,
&keyPayloadSignature,
&contentPrekey,
&contentPrekeySignature,
&notifPrekey,
&notifPrekeySignature,
&contentOneTimeKeys,
&notifOneTimeKeys](
jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityRegisterUser(
jsiStringToRustString(username, innerRt),
jsiStringToRustString(password, innerRt),
jsiStringToRustString(keyPayload, innerRt),
jsiStringToRustString(keyPayloadSignature, innerRt),
jsiStringToRustString(contentPrekey, innerRt),
jsiStringToRustString(contentPrekeySignature, innerRt),
jsiStringToRustString(notifPrekey, innerRt),
jsiStringToRustString(notifPrekeySignature, innerRt),
jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
jsi::Value CommCoreModule::loginPasswordUser(
jsi::Runtime &rt,
jsi::String username,
jsi::String password,
jsi::String keyPayload,
jsi::String keyPayloadSignature,
jsi::String contentPrekey,
jsi::String contentPrekeySignature,
jsi::String notifPrekey,
jsi::String notifPrekeySignature,
jsi::Array contentOneTimeKeys,
jsi::Array notifOneTimeKeys) {
return createPromiseAsJSIValue(
rt,
[this,
&username,
&password,
&keyPayload,
&keyPayloadSignature,
&contentPrekey,
&contentPrekeySignature,
&notifPrekey,
&notifPrekeySignature,
&contentOneTimeKeys,
&notifOneTimeKeys](
jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityLoginPasswordUser(
jsiStringToRustString(username, innerRt),
jsiStringToRustString(password, innerRt),
jsiStringToRustString(keyPayload, innerRt),
jsiStringToRustString(keyPayloadSignature, innerRt),
jsiStringToRustString(contentPrekey, innerRt),
jsiStringToRustString(contentPrekeySignature, innerRt),
jsiStringToRustString(notifPrekey, innerRt),
jsiStringToRustString(notifPrekeySignature, innerRt),
jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
jsi::Value CommCoreModule::loginWalletUser(
jsi::Runtime &rt,
jsi::String siweMessage,
jsi::String siweSignature,
jsi::String keyPayload,
jsi::String keyPayloadSignature,
jsi::String contentPrekey,
jsi::String contentPrekeySignature,
jsi::String notifPrekey,
jsi::String notifPrekeySignature,
jsi::Array contentOneTimeKeys,
jsi::Array notifOneTimeKeys,
jsi::String socialProof) {
return createPromiseAsJSIValue(
rt,
[this,
&siweMessage,
&siweSignature,
&keyPayload,
&keyPayloadSignature,
&contentPrekey,
&contentPrekeySignature,
&notifPrekey,
&notifPrekeySignature,
&contentOneTimeKeys,
&notifOneTimeKeys,
&socialProof](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityLoginWalletUser(
jsiStringToRustString(siweMessage, innerRt),
jsiStringToRustString(siweSignature, innerRt),
jsiStringToRustString(keyPayload, innerRt),
jsiStringToRustString(keyPayloadSignature, innerRt),
jsiStringToRustString(contentPrekey, innerRt),
jsiStringToRustString(contentPrekeySignature, innerRt),
jsiStringToRustString(notifPrekey, innerRt),
jsiStringToRustString(notifPrekeySignature, innerRt),
jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
jsiStringToRustString(socialProof, innerRt),
currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
} // namespace comm } // namespace comm