Differential D3671

[web] Adjust `MembersModal` size to match designs
ClosedPublic
Actions

Authored by • jacek on Apr 8 2022, 5:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 5, 4:23 AM

	Unknown Object (File)
	Mon, Oct 21, 2:21 AM

	Unknown Object (File)
	Fri, Oct 18, 7:14 AM

	Unknown Object (File)
	Fri, Oct 18, 6:49 AM

	Unknown Object (File)
	Fri, Oct 18, 4:20 AM

	Unknown Object (File)
	Oct 9 2024, 7:07 PM

	Unknown Object (File)
	Oct 9 2024, 7:07 PM

	Unknown Object (File)
	Oct 9 2024, 7:07 PM

Subscribers

Details

Reviewers

tomek
atul
• benschac

Commits

rCOMM7daabdc391c1: [web] Adjust `MembersModal` size to match designs

Summary

Changed MembersModal content size in order to make the whole modal size exactly the same as in design.

Screenshot_Google Chrome_2022-04-11_084216.png (955×1 px, 140 KB)

Test Plan

Open Members modal from thread actions menu.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Apr 8 2022, 5:58 AM

Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 8 2022, 5:58 AM

• jacek added a parent revision: D3670: [web] Allow passing `Modal` parameters into `SearchModal`.Apr 8 2022, 5:59 AM

• jacek added a parent revision: D3669: [web] Redesign `Modal` to match Figma.

Harbormaster completed remote builds in B8023: Diff 11228.Apr 8 2022, 6:05 AM

• jacek requested review of this revision.Apr 8 2022, 6:05 AM

• jacek added reviewers: tomek, atul, • benschac.Apr 8 2022, 6:07 AM

(would be good to add a screenshot just to see how it looks with these dimensions)

web/modals/threads/members/members-modal.css
2–3 ↗	(On Diff #11228)	(I don't think we need to match the dimensions from Figma exactly, I don't think those designs were intended to be pixel perfect... but if it looks good then it's fine)

This revision is now accepted and ready to land.Apr 8 2022, 11:20 AM

atul mentioned this in D3672: [web] Adjust `SubchannelsModal` size to match designs.Apr 8 2022, 11:22 AM

• jacek edited the summary of this revision. (Show Details)Apr 10 2022, 11:42 PM

rebase

Harbormaster completed remote builds in B8522: Diff 11881.Apr 25 2022, 10:46 AM

rebase

Harbormaster completed remote builds in B8557: Diff 11926.Apr 26 2022, 8:52 AM

Closed by commit rCOMM7daabdc391c1: [web] Adjust `MembersModal` size to match designs (authored by • jacek). · Explain WhyApr 26 2022, 9:09 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM7daabdc391c1: [web] Adjust `MembersModal` size to match designs.

Revision Contents
Changeset List

Path

Size

web/

components/

1 line

modals/

threads/

members/

members-modal.css

5 lines

members-modal.react.js

12 lines

Diff 11938

web/components/tabs.css

Loading...

web/modals/threads/members/members-modal.css

Loading...

web/modals/threads/members/members-modal.react.js

Loading...