Page MenuHomePhabricator

[web] Adjust `MembersModal` size to match designs
ClosedPublic

Authored by jacek on Apr 8 2022, 5:58 AM.
Tags
None
Referenced Files
F3367124: D3671.id11938.diff
Mon, Nov 25, 1:48 PM
Unknown Object (File)
Sun, Nov 10, 7:34 AM
Unknown Object (File)
Tue, Nov 5, 4:23 AM
Unknown Object (File)
Oct 21 2024, 2:21 AM
Unknown Object (File)
Oct 18 2024, 7:14 AM
Unknown Object (File)
Oct 18 2024, 6:49 AM
Unknown Object (File)
Oct 18 2024, 4:20 AM
Unknown Object (File)
Oct 9 2024, 7:07 PM

Details

Summary

Changed MembersModal content size in order to make the whole modal size exactly the same as in design.

Screenshot_Google Chrome_2022-04-11_084216.png (955×1 px, 140 KB)

Test Plan

Open Members modal from thread actions menu.

Diff Detail

Repository
rCOMM Comm
Branch
jacek/modal-7
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

(would be good to add a screenshot just to see how it looks with these dimensions)

web/modals/threads/members/members-modal.css
2–3

(I don't think we need to match the dimensions from Figma exactly, I don't think those designs were intended to be pixel perfect... but if it looks good then it's fine)

This revision is now accepted and ready to land.Apr 8 2022, 11:20 AM