Page MenuHomePhabricator

[web] Introduce searching users in `AddMembersModal`
ClosedPublic

Authored by jacek on Apr 15 2022, 4:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 3:55 AM
Unknown Object (File)
Tue, Oct 29, 12:32 PM
Unknown Object (File)
Tue, Oct 29, 12:32 PM
Unknown Object (File)
Wed, Oct 16, 8:41 AM
Unknown Object (File)
Wed, Oct 16, 8:41 AM
Unknown Object (File)
Wed, Oct 16, 8:41 AM
Unknown Object (File)
Tue, Oct 15, 2:36 PM
Unknown Object (File)
Sat, Oct 12, 1:11 PM

Details

Summary

Add logic responsible for finding users, that can be added (or not) to the thread based on search query. Used getPotentialMemberItems lib function, that is used in native app.

Screenshot_Google Chrome_2022-04-15_135513.png (516×470 px, 27 KB)

Test Plan

The search can be tested after introducing button activating AddMembersModal - search results should be exactly the same as in mobile app for the same query.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek added inline comments.
web/modals/threads/members/add-members-modal.react.js
47–57 ↗(On Diff #11513)

This can be simplified a bit

This revision is now accepted and ready to land.Apr 15 2022, 9:35 AM