Details

Reviewers

tomek
atul
• benschac

Commits

rCOMMa5d44d43531c: [web] Introduce `AddMembersItem` component

Summary

Introduce component rendering single user on the list in AddMembersModal. Because I shared some common logic with native, user information are passed in UserListItem type.

GIF presenting the items:

Screenshot_Google Chrome_2022-04-15_130227.gif (334×442 px, 336 KB)

Test Plan

Component can be tested after introducing AddMembersModal

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Apr 15 2022, 3:57 AM

Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 15 2022, 3:57 AM

• jacek edited the summary of this revision. (Show Details)Apr 15 2022, 4:03 AM

• jacek added a parent revision: D3670: [web] Allow passing `Modal` parameters into `SearchModal`.

• jacek added a parent revision: D3669: [web] Redesign `Modal` to match Figma.

• jacek edited the summary of this revision. (Show Details)

• jacek added a child revision: D3740: [web] Introduce `AddMemberGroup` component.Apr 15 2022, 4:12 AM

• jacek added reviewers: tomek, atul, • benschac.Apr 15 2022, 4:51 AM

Harbormaster completed remote builds in B8225: Diff 11509.Apr 15 2022, 8:15 AM

• jacek requested review of this revision.Apr 15 2022, 8:15 AM

tomek requested changes to this revision.Apr 15 2022, 9:03 AM

tomek added inline comments.

web/modals/threads/members/add-members-item.react.js
19 ↗	(On Diff #11509)	Could you explain what happens here? Why `userInfo.alertTitle === undefined` means that user can be added?
28–30 ↗	(On Diff #11509)	The returned value will be different after each render, so we should probably memoize it
44 ↗	(On Diff #11509)	We should prefer `button` - it's more semantic. We can also set `disabled` attribute when `!canBeAdded`
45–46 ↗	(On Diff #11509)	Why do we need two separate classes for them?

This revision now requires changes to proceed.Apr 15 2022, 9:03 AM

• jacek planned changes to this revision.Apr 19 2022, 11:27 AM

• jacek added inline comments.

web/modals/threads/members/add-members-item.react.js
19 ↗	(On Diff #11509)	It requires some explanation, because it's a bit strange. This is how it's currently implemented in React Native. In the mobile app, the callback that adds user is not executed if `UserListItem` have `alertText` set: https://github.com/CommE2E/comm/blob/master/native/components/user-list-user.react.js#L57-L60 These values are set in: https://github.com/CommE2E/comm/blob/master/lib/shared/search-utils.js#L113-L137 In fact, I should have checked `alertText` instead `alertTitle`, so I'll correct it, although both these fields are filled together and it also works correctly now.
28–30 ↗	(On Diff #11509)	Are you sure it will? I did a quick test, and it seems that the value doesn't change between renders. Maybe the `classNames` library has some optimizations?
44 ↗	(On Diff #11509)	I think the best semantic matching tag would be here `li` as it's more an element of the list (although is clickable).
45–46 ↗	(On Diff #11509)	I think it can even be simplified by using, `.addMemberItem > div` selector in CSS. What do you think? Or should I leave a separate class name for the items in such case?

Updates following review comments

Harbormaster completed remote builds in B8437: Diff 11776.Apr 22 2022, 3:42 AM

tomek requested changes to this revision.Apr 25 2022, 6:28 AM

tomek added inline comments.

web/modals/threads/members/add-members-item.react.js
18 ↗	(On Diff #11776)	In fact, I should have checked alertText instead alertTitle, so I'll correct it, although both these fields are filled together and it also works correctly now. You're still using `alertTitle`. Also, I think it will be safer to use `!userInfo.alertText`.
28–30 ↗	(On Diff #11509)	It's better to check their source code. But even if their code does a memoization, it is safer for us to do the same, just to avoid issues when upgrading the library. It doesn't matter any more, as we're no longer using it here.
44 ↗	(On Diff #11509)	If we really want to be correct, we should probably wrap `button` with `li`. But for now `button` sounds like a good enough solution.
45–46 ↗	(On Diff #11509)	It's more maintainable to use classes - we avoid accidental changes. But at this point, it looks like `.addMemberName` and `.addMemberAction` are used but not defined. We can e.g. introduce a new class `.label` and use it instead of `button.addMemberItem > div`.

This revision now requires changes to proceed.Apr 25 2022, 6:28 AM

replace alertTitle with alertText and change css class name to label

web/modals/threads/members/add-members-item.react.js
18 ↗	(On Diff #11776)	Sorry for missing it

Harbormaster completed remote builds in B8505: Diff 11864.Apr 25 2022, 6:58 AM

tomek accepted this revision.Apr 25 2022, 6:58 AM

This revision is now accepted and ready to land.Apr 25 2022, 6:58 AM

rebase

Harbormaster completed remote builds in B8586: Diff 11967.Apr 27 2022, 2:38 AM

rebase

Harbormaster completed remote builds in B8687: Diff 12098.Apr 29 2022, 3:21 AM

Closed by commit rCOMMa5d44d43531c: [web] Introduce `AddMembersItem` component (authored by • jacek). · Explain WhyApr 29 2022, 3:44 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMMa5d44d43531c: [web] Introduce `AddMembersItem` component.

Diff 12106

View Options

web/modals/threads/members/add-members-item.react.js

	#include "CommCoreModule.h"			#include "CommCoreModule.h"
	#include "../CryptoTools/DeviceID.h"			#include "../CryptoTools/DeviceID.h"
	#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"			#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"
	#include "BaseDataStore.h"			#include "BaseDataStore.h"
	#include "DatabaseManager.h"			#include "DatabaseManager.h"
	#include "InternalModules/GlobalDBSingleton.h"			#include "InternalModules/GlobalDBSingleton.h"
	#include "InternalModules/RustPromiseManager.h"
	#include "NativeModuleUtils.h"			#include "NativeModuleUtils.h"
	#include "TerminateApp.h"			#include "TerminateApp.h"
	#include "lib.rs.h"

	#include <ReactCommon/TurboModuleUtils.h>			#include <ReactCommon/TurboModuleUtils.h>
	#include <folly/dynamic.h>			#include <folly/dynamic.h>
	#include <folly/json.h>			#include <folly/json.h>
	#include <future>			#include <future>

	namespace comm {			namespace comm {

	▲ Show 20 Lines • Show All 782 Lines • ▼ Show 20 Lines
	bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {			bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {
	return DatabaseManager::checkIfDatabaseNeedsDeletion();			return DatabaseManager::checkIfDatabaseNeedsDeletion();
	}			}

	void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {			void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {
	DatabaseManager::reportDBOperationsFailure();			DatabaseManager::reportDBOperationsFailure();
	}			}

	jsi::Value CommCoreModule::generateNonce(jsi::Runtime &rt) {
	return createPromiseAsJSIValue(
	rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityGenerateNonce(currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::registerUser(
	jsi::Runtime &rt,
	jsi::String username,
	jsi::String password,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&username,
	&password,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys](
	jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityRegisterUser(
	jsiStringToRustString(username, innerRt),
	jsiStringToRustString(password, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::loginPasswordUser(
	jsi::Runtime &rt,
	jsi::String username,
	jsi::String password,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&username,
	&password,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys](
	jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityLoginPasswordUser(
	jsiStringToRustString(username, innerRt),
	jsiStringToRustString(password, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::loginWalletUser(
	jsi::Runtime &rt,
	jsi::String siweMessage,
	jsi::String siweSignature,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys,
	jsi::String socialProof) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&siweMessage,
	&siweSignature,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys,
	&socialProof](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityLoginWalletUser(
	jsiStringToRustString(siweMessage, innerRt),
	jsiStringToRustString(siweSignature, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	jsiStringToRustString(socialProof, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	} // namespace comm			} // namespace comm

View Options

web/modals/threads/members/members-modal.css

	#include "CommCoreModule.h"			#include "CommCoreModule.h"
	#include "../CryptoTools/DeviceID.h"			#include "../CryptoTools/DeviceID.h"
	#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"			#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"
	#include "BaseDataStore.h"			#include "BaseDataStore.h"
	#include "DatabaseManager.h"			#include "DatabaseManager.h"
	#include "InternalModules/GlobalDBSingleton.h"			#include "InternalModules/GlobalDBSingleton.h"
	#include "InternalModules/RustPromiseManager.h"
	#include "NativeModuleUtils.h"			#include "NativeModuleUtils.h"
	#include "TerminateApp.h"			#include "TerminateApp.h"
	#include "lib.rs.h"

	#include <ReactCommon/TurboModuleUtils.h>			#include <ReactCommon/TurboModuleUtils.h>
	#include <folly/dynamic.h>			#include <folly/dynamic.h>
	#include <folly/json.h>			#include <folly/json.h>
	#include <future>			#include <future>

	namespace comm {			namespace comm {

	▲ Show 20 Lines • Show All 782 Lines • ▼ Show 20 Lines
	bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {			bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {
	return DatabaseManager::checkIfDatabaseNeedsDeletion();			return DatabaseManager::checkIfDatabaseNeedsDeletion();
	}			}

	void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {			void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {
	DatabaseManager::reportDBOperationsFailure();			DatabaseManager::reportDBOperationsFailure();
	}			}

	jsi::Value CommCoreModule::generateNonce(jsi::Runtime &rt) {
	return createPromiseAsJSIValue(
	rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityGenerateNonce(currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::registerUser(
	jsi::Runtime &rt,
	jsi::String username,
	jsi::String password,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&username,
	&password,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys](
	jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityRegisterUser(
	jsiStringToRustString(username, innerRt),
	jsiStringToRustString(password, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::loginPasswordUser(
	jsi::Runtime &rt,
	jsi::String username,
	jsi::String password,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&username,
	&password,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys](
	jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityLoginPasswordUser(
	jsiStringToRustString(username, innerRt),
	jsiStringToRustString(password, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::loginWalletUser(
	jsi::Runtime &rt,
	jsi::String siweMessage,
	jsi::String siweSignature,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys,
	jsi::String socialProof) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&siweMessage,
	&siweSignature,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys,
	&socialProof](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityLoginWalletUser(
	jsiStringToRustString(siweMessage, innerRt),
	jsiStringToRustString(siweSignature, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	jsiStringToRustString(socialProof, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	} // namespace comm			} // namespace comm

View Options

web/theme.css

	#include "CommCoreModule.h"			#include "CommCoreModule.h"
	#include "../CryptoTools/DeviceID.h"			#include "../CryptoTools/DeviceID.h"
	#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"			#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"
	#include "BaseDataStore.h"			#include "BaseDataStore.h"
	#include "DatabaseManager.h"			#include "DatabaseManager.h"
	#include "InternalModules/GlobalDBSingleton.h"			#include "InternalModules/GlobalDBSingleton.h"
	#include "InternalModules/RustPromiseManager.h"
	#include "NativeModuleUtils.h"			#include "NativeModuleUtils.h"
	#include "TerminateApp.h"			#include "TerminateApp.h"
	#include "lib.rs.h"

	#include <ReactCommon/TurboModuleUtils.h>			#include <ReactCommon/TurboModuleUtils.h>
	#include <folly/dynamic.h>			#include <folly/dynamic.h>
	#include <folly/json.h>			#include <folly/json.h>
	#include <future>			#include <future>

	namespace comm {			namespace comm {

	▲ Show 20 Lines • Show All 782 Lines • ▼ Show 20 Lines
	bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {			bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {
	return DatabaseManager::checkIfDatabaseNeedsDeletion();			return DatabaseManager::checkIfDatabaseNeedsDeletion();
	}			}

	void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {			void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {
	DatabaseManager::reportDBOperationsFailure();			DatabaseManager::reportDBOperationsFailure();
	}			}

	jsi::Value CommCoreModule::generateNonce(jsi::Runtime &rt) {
	return createPromiseAsJSIValue(
	rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityGenerateNonce(currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::registerUser(
	jsi::Runtime &rt,
	jsi::String username,
	jsi::String password,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&username,
	&password,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys](
	jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityRegisterUser(
	jsiStringToRustString(username, innerRt),
	jsiStringToRustString(password, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::loginPasswordUser(
	jsi::Runtime &rt,
	jsi::String username,
	jsi::String password,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&username,
	&password,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys](
	jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityLoginPasswordUser(
	jsiStringToRustString(username, innerRt),
	jsiStringToRustString(password, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::loginWalletUser(
	jsi::Runtime &rt,
	jsi::String siweMessage,
	jsi::String siweSignature,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys,
	jsi::String socialProof) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&siweMessage,
	&siweSignature,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys,
	&socialProof](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityLoginWalletUser(
	jsiStringToRustString(siweMessage, innerRt),
	jsiStringToRustString(siweSignature, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	jsiStringToRustString(socialProof, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	} // namespace comm			} // namespace comm

[web] Introduce `AddMembersItem` component
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 12106

web/modals/threads/members/add-members-item.react.js

web/modals/threads/members/members-modal.css

web/theme.css

[web] Introduce `AddMembersItem` componentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12106

web/modals/threads/members/add-members-item.react.js

web/modals/threads/members/members-modal.css

web/theme.css

[web] Introduce `AddMembersItem` component
ClosedPublic
Actions

Revision Contents
Changeset List