Page MenuHomePhabricator
Differential D3672

[web] Adjust `SubchannelsModal` size to match designs
ClosedPublic
Actions

Authored by • jacek on Apr 8 2022, 5:59 AM.
Tags
None
Referenced Files
F5950467: D3672.id11927.diff
Fri, Apr 18, 1:55 PM
F5945207: D3672.id11882.diff
Fri, Apr 18, 9:15 AM
F5943560: D3672.id11937.diff
Fri, Apr 18, 8:45 AM
F5933306: D3672.id.diff
Fri, Apr 18, 5:34 AM
Unknown Object (File)
Fri, Apr 18, 1:43 AM
Unknown Object (File)
Thu, Apr 17, 1:58 AM
Unknown Object (File)
Tue, Apr 15, 7:40 PM
Unknown Object (File)
Tue, Apr 8, 6:52 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
tomek
atul
• benschac
Commits
rCOMMd8e2452fd22d: [web] Adjust `SubchannelsModal` size to match designs
Summary

Changed SubchannelsModal content size to match design in Figma.

Screenshot_Google Chrome_2022-04-11_084329.png (956×1 px, 139 KB)

Test Plan

Open SubchannelsModal from thread actions menu

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jacek created this revision.Apr 8 2022, 5:59 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 8 2022, 5:59 AM
• jacek added a parent revision: D3670: [web] Allow passing `Modal` parameters into `SearchModal`.Apr 8 2022, 6:01 AM
• jacek added reviewers: tomek, atul, • benschac.Apr 8 2022, 6:08 AM
Harbormaster completed remote builds in B8024: Diff 11229.Apr 8 2022, 6:09 AM
• jacek requested review of this revision.Apr 8 2022, 6:09 AM
atul accepted this revision.Apr 8 2022, 11:22 AM

(see: https://phabricator.ashoat.com/D3671#100936)

This revision is now accepted and ready to land.Apr 8 2022, 11:22 AM
• jacek edited the summary of this revision. (Show Details)Apr 10 2022, 11:44 PM
• jacek added a parent revision: D3669: [web] Redesign `Modal` to match Figma.Apr 22 2022, 3:44 AM
• jacek updated this revision to Diff 11882.Apr 25 2022, 10:29 AM

rebase

Harbormaster completed remote builds in B8523: Diff 11882.Apr 25 2022, 10:47 AM
• jacek updated this revision to Diff 11927.Apr 26 2022, 8:35 AM

rebase

Harbormaster completed remote builds in B8558: Diff 11927.Apr 26 2022, 8:53 AM
Closed by commit rCOMMd8e2452fd22d: [web] Adjust `SubchannelsModal` size to match designs (authored by • jacek). · Explain WhyApr 26 2022, 9:09 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMMd8e2452fd22d: [web] Adjust `SubchannelsModal` size to match designs.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
subchannels/
2 lines
1 line

Diff 11937

View Options

web/modals/threads/subchannels/subchannels-modal.css

#!/usr/bin/env bash #!/usr/bin/env bash
# Check if shell is using a default BSD or GNU prompt
if [[ ${PS1} != '\s-\v\$'* ]] && \
[[ ${PS1} != '%n@%m %1~ %#'* ]]; then
# User already has an opinionated PS1, just leave
return 0
fi
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm"
else else
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm"
fi fi
COMM_EMITTED_WARNING="$COMM_CACHE/powerline_warning" mkdir -p "$COMM_CACHE"
COMM_POWERLINE="$COMM_CACHE/enable-powerline"
# Only emit this the first time, as it's suprising to the user for the prompt # Only emit this the first time, as it's suprising to the user for the prompt
# to be replaced, but avoid emitting the warning on subsequent invocations # to be replaced, but avoid emitting the warning on subsequent invocations
if [[ ! -f "$COMM_EMITTED_WARNING" ]]; then if [[ ! -e "${COMM_POWERLINE}" ]]; then
echo "Default prompt found, attempting to enable powerline" >&2 read -r \
-p "Would you like to enable Powerline as the default bash prompt? [y/N] " \
response
case "$response" in
[yY][eE][sS]|[yY])
echo "1" > "${COMM_POWERLINE}"
;;
*)
touch "${COMM_POWERLINE}"
;;
esac
fi
# Create file to ensure it exists for next time this is run # If empty, user want's to use native prompt
mkdir -p "$COMM_CACHE" if [[ ! -s "${COMM_POWERLINE}" ]]; then
touch "$COMM_EMITTED_WARNING" return 0
fi fi
# Check if the powerline fonts are installed # Check if the powerline fonts are installed
# If the font is missing then many of the glyphs will render as ? # If the font is missing then many of the glyphs will render as ?
# Adapted from https://github.com/powerline/fonts/blob/master/install.sh # Adapted from https://github.com/powerline/fonts/blob/master/install.sh
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
# MacOS # MacOS
font_dir="$HOME/Library/Fonts" font_dir="$HOME/Library/Fonts"
else else
# Linux # Linux
font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts" font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts"
mkdir -p "$font_dir" mkdir -p "$font_dir"
fi fi
if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then
if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then
echo "Unable to determine powerline fonts location" >&2 echo "Unable to determine powerline fonts location" >&2
return 1 return 1
fi fi
echo "Installing powerline fonts" >&2 echo "Installing Powerline fonts" >&2
find "$powerline_fonts" \ find "$powerline_fonts" \
\( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \ \( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \
| xargs -0 -n1 -I % cp "%" "$font_dir/" | xargs -0 -n1 -I % cp "%" "$font_dir/"
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then
echo "For glyph support, please: echo "For glyph support, please:
Show All 17 Lines
View Options

web/modals/threads/subchannels/subchannels-modal.react.js

#!/usr/bin/env bash #!/usr/bin/env bash
# Check if shell is using a default BSD or GNU prompt
if [[ ${PS1} != '\s-\v\$'* ]] && \
[[ ${PS1} != '%n@%m %1~ %#'* ]]; then
# User already has an opinionated PS1, just leave
return 0
fi
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/Library/Caches}/app.comm"
else else
COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm" COMM_CACHE="${XDG_CACHE_HOME:-$HOME/.cache}/comm"
fi fi
COMM_EMITTED_WARNING="$COMM_CACHE/powerline_warning" mkdir -p "$COMM_CACHE"
COMM_POWERLINE="$COMM_CACHE/enable-powerline"
# Only emit this the first time, as it's suprising to the user for the prompt # Only emit this the first time, as it's suprising to the user for the prompt
# to be replaced, but avoid emitting the warning on subsequent invocations # to be replaced, but avoid emitting the warning on subsequent invocations
if [[ ! -f "$COMM_EMITTED_WARNING" ]]; then if [[ ! -e "${COMM_POWERLINE}" ]]; then
echo "Default prompt found, attempting to enable powerline" >&2 read -r \
-p "Would you like to enable Powerline as the default bash prompt? [y/N] " \
response
case "$response" in
[yY][eE][sS]|[yY])
echo "1" > "${COMM_POWERLINE}"
;;
*)
touch "${COMM_POWERLINE}"
;;
esac
fi
# Create file to ensure it exists for next time this is run # If empty, user want's to use native prompt
mkdir -p "$COMM_CACHE" if [[ ! -s "${COMM_POWERLINE}" ]]; then
touch "$COMM_EMITTED_WARNING" return 0
fi fi
# Check if the powerline fonts are installed # Check if the powerline fonts are installed
# If the font is missing then many of the glyphs will render as ? # If the font is missing then many of the glyphs will render as ?
# Adapted from https://github.com/powerline/fonts/blob/master/install.sh # Adapted from https://github.com/powerline/fonts/blob/master/install.sh
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
# MacOS # MacOS
font_dir="$HOME/Library/Fonts" font_dir="$HOME/Library/Fonts"
else else
# Linux # Linux
font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts" font_dir="${XDG_DATA_HOME:-$HOME/.local/share}/fonts"
mkdir -p "$font_dir" mkdir -p "$font_dir"
fi fi
if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then if [[ ! -f "$font_dir/Droid Sans Mono for Powerline.otf" ]]; then
if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then if [[ ! -d "${powerline_fonts:-/doesnt-exist}" ]]; then
echo "Unable to determine powerline fonts location" >&2 echo "Unable to determine powerline fonts location" >&2
return 1 return 1
fi fi
echo "Installing powerline fonts" >&2 echo "Installing Powerline fonts" >&2
find "$powerline_fonts" \ find "$powerline_fonts" \
\( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \ \( -name "*.[ot]tf" -or -name "*.pcf.gz" \) -type f -print0 \
| xargs -0 -n1 -I % cp "%" "$font_dir/" | xargs -0 -n1 -I % cp "%" "$font_dir/"
if test "$(uname)" = "Darwin" ; then if test "$(uname)" = "Darwin" ; then
if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then if [[ "$TERM_PROGRAM" == "Apple_Terminal" ]]; then
echo "For glyph support, please: echo "For glyph support, please:
Show All 17 Lines