Page MenuHomePhabricator

[Identity] Add tracing to the Identity service
ClosedPublic

Authored by varun on Apr 25 2022, 8:46 PM.
Tags
None
Referenced Files
F3113685: D3852.diff
Thu, Oct 31, 6:20 PM
Unknown Object (File)
Mon, Oct 28, 12:06 PM
Unknown Object (File)
Sun, Oct 27, 6:05 PM
Unknown Object (File)
Sun, Oct 27, 6:04 PM
Unknown Object (File)
Sun, Oct 27, 6:04 PM
Unknown Object (File)
Sun, Oct 27, 6:04 PM
Unknown Object (File)
Sun, Oct 13, 9:19 PM
Unknown Object (File)
Sun, Oct 13, 9:19 PM

Details

Summary

Tracing provides structured logging and diagnostics info. It's especially helpful for asynchronous programs where log lines for various tasks can get intermixed.

Test Plan

Checked that detailed error logs appeared in my terminal

Diff Detail

Repository
rCOMM Comm
Branch
varun/identity_service (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Apr 25 2022, 8:51 PM
services/identity/src/main.rs
19

The string slice passed to expect shows up in the panic message, so we actually want to express that loading config failed here

services/identity/src/main.rs
12

Can we just omit this?

tomek added a reviewer: ashoat. tomek added 1 blocking reviewer(s): karol.

Adding @ashoat as we're adding a new library

Acceptin' as this looks good and my comment is just a nit, but please respond, thanks!

This revision is now accepted and ready to land.Apr 27 2022, 11:58 PM
services/identity/src/main.rs
12

yeah, changed it to tracing::subscriber::set_global_default(subscriber)?;

varun marked an inline comment as done.May 4 2022, 1:16 PM