[Identity] DatabaseClient method to put pake registration data
ClosedPublic
Actions

Authored by varun on May 6 2022, 12:51 PM.

Details

Reviewers

• jim
• karol
tomek

Commits

rCOMM5c78899a099c: [Identity] DatabaseClient method to put pake registration data

Summary

The client will use this method to put PAKE registration data in our DynamoDB table. We serialize the ServerRegistration object and store it as bytes.

Depends on D3959

Test Plan

Successfully put an item in the PAKE registration table in DynamoDB

Diff Detail

Repository

rCOMM Comm

Branch

varun/identity_service (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.May 6 2022, 12:51 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 6 2022, 12:51 PM

Harbormaster completed remote builds in B8881: Diff 12383.May 6 2022, 12:55 PM

varun requested review of this revision.May 6 2022, 12:55 PM

Remove unnecessary clone

Harbormaster completed remote builds in B8882: Diff 12385.May 6 2022, 1:12 PM

varun added a child revision: D3961: [Identity] Add new Error variant.May 6 2022, 1:26 PM

• karol mentioned this in D3957: [Identity] DatabaseClient method to get user token.May 9 2022, 4:31 AM

As in other diffs: wondering if we can avoid boilerplate?

This revision is now accepted and ready to land.May 9 2022, 4:38 AM

I'm not sure why this is in an "accepted" state. I hope it cannot be landed... After I accept, rust diffs should not be accepted, I know rust far too little to be decisive. Adding Jim as blocking.

This revision now requires review to proceed.May 9 2022, 4:54 AM

• jim accepted this revision.May 9 2022, 10:16 AM

This revision is now accepted and ready to land.May 9 2022, 10:16 AM

In D3960#110942, @karol-bisztyga wrote:

As in other diffs: wondering if we can avoid boilerplate?

I will move the Strings to a consts module as discussed on another diff, but the code here is unavoidable. We remove some of the boilerplate code by using the Default trait.

Closed by commit rCOMM5c78899a099c: [Identity] DatabaseClient method to put pake registration data (authored by varun). · Explain WhyMay 27 2022, 12:54 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM5c78899a099c: [Identity] DatabaseClient method to put pake registration data.