We can remove this, ok

yes, we can use match, thx!

I don't think so, if you have something specific on your mind, please, let me know

seems redundant

I couldn't find a better way to do this, maybe @varun can help with this?

I may not be remembering this 100% correctly now, but:

The problem was with how the tests work vs how the program with main works. In main you need to only once declare the mod and then you can import it in other files, right?
In the tests, you have to define the module in every test file and the problem is how rust resolves these mods.
Imagine you have:

- a
- dir
  - b
  - c

now:

• in b you have a struct
• in c you have a function that takes this struct as an arg
• in a you try to invoke this function and pass some object created in a

Without paths like this, you'll end up with something like type mismatch, expected c::structx, received a::structx (or received b::structx I don't remember).

I do not see a point in doing so.
This enum looks liker this:

pub mod pull_backup_response {
  #[derive(Clone, PartialEq, ::prost::Oneof)]
  pub enum Data {
    #[prost(bytes, tag = "1")]
    CompactionChunk(::prost::alloc::vec::Vec<u8>),
    #[prost(bytes, tag = "2")]
    LogChunk(::prost::alloc::vec::Vec<u8>),
    #[prost(string, tag = "3")]
    AttachmentHolders(::prost::alloc::string::String),
  }
}

There's no redundancy, we use everything we import. Why would you like the explicit list here?

We need this so we can compare the values of the objects of this enum. What do you mean how does it work? I'm just not sure what's unclear, I bet you already know this https://doc.rust-lang.org/reference/attributes/derive.html.

It's more clear to me when it's there. If you really think it's annoying, I can remove this.

yes

Yes, good catch, I'll try to debug this, thanks.

we cannot but the compiler forces the None section. I think we can panic here.

Ok I checked and None seems to be sent when the connection's being terminated, so we should NOT panic.

I fixed this bug in D4341

Unfortunately, that does not help. They show a very simple example. I created a minimal repro which shows our case: https://github.com/karol-bisztyga/rust-tests-paths-repro

You can try to remove all occurrences of #[path = "./tools.rs"] and see what happens.

What is the problem with keeping this and in a case of a collision listing all items manually and using as? I mean, as long as it works as it is, I think we're good. If it breaks, we can easily fix this but until it works, the shorter form the better.

I'd leave this as is. If you feel strongly, we can start a discussion about this and get someone else's vote about this.

good idea

D4379

Sorry wrong diff, I couldn't make it work there

https://linear.app/comm/issue/ENG-1322/move-constants-to-a-separate-file