Details

Reviewers

tomek
• karol
varun

Commits

rCOMM65b7c27c4c10: Implement interface for inter process non-blocking binary lock based on POSIX…

Summary

Implement methods from parent diff

Test Plan

Temporarily modify NotificationService and AppDelegate so that the first writes notification to a file from which the second reads upon app launch. Cover reads and writes with semaphore operations. Use debugger to hold semaphore in AppDelegate, trigger notification and see that NotificationService did not acquire semaphore (simply logs it).

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Jun 28 2022, 8:32 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 28 2022, 8:32 AM

Harbormaster completed remote builds in B10056: Diff 13905.Jun 28 2022, 8:42 AM

marcin requested review of this revision.Jun 28 2022, 8:42 AM

marcin added a parent revision: D4380: Define interface for inter process non-blocking binary lock based on POSIX semaphore.Jun 29 2022, 2:34 AM

marcin added a child revision: D4382: Define interface for elementary file operations: atomic write, append, read and atomic truncation with encryption-decryption layer based on encryption key in CommSecureStore.

tomek accepted this revision.Jun 29 2022, 6:11 AM

This revision is now accepted and ready to land.Jun 29 2022, 6:11 AM

Introduce files to project.pbxproj

Harbormaster completed remote builds in B10184: Diff 14062.Jul 1 2022, 2:12 AM

marcin edited the test plan for this revision. (Show Details)Jul 1 2022, 2:47 AM

Add proper error handling to destroyLock method.

Harbormaster failed remote builds in B10257: Diff 14149!Jul 5 2022, 3:19 AM

Rebase master

Harbormaster completed remote builds in B10268: Diff 14160.Jul 5 2022, 4:22 AM

ashoat added inline comments.Jul 5 2022, 11:56 AM

native/ios/Comm/TemporalMessageStorage/NonBlockingLock.mm
15–42	Spacing here looks broken. Is this really how XCode is formatting it? Can we try to improve this?

marcin added inline comments.Jul 7 2022, 5:57 AM

native/ios/Comm/TemporalMessageStorage/NonBlockingLock.mm
15–42	I don't use XCode for formatting - I rely on `yarn clang-format-all` command. Spacing here looks broken. What exactly do you refer to? I think you may refer to `NSLocalizedDescriptionKey : [NSString`. Actually spacing is correct here. Additional space is introduced between `NSLocalizedDescriptionKey` and `:` since it is not a method call but initialization of Objective - C dictionary. We do no introduce before after `:` if it precedes argument in method call, but we do so if it precedes value under a given key in Objective-C dictionary initialization. Example: https://stackoverflow.com/questions/9195573/initializing-nsdictionary.