This differential is a refactor that enables to share database worker thread between AppDelegate and CommCoreModule. We suspect that the reason for iOS 137 crash is that we access SQLite database from thread upon rescind when some other database operations is being executed on databaseThread of CommCoreModule. Sharing database thread with CommCoreModule and AppDelegate should remedy the crash then. IMPORTANT: this revision is not going to be landed. We will create release build with its commit, push to the master and revert it. Therefore it is acceptable that code here is not 100% clean. We only want it to work to either confirm or refute our theory. If it happens to be a remedy for the crash we will create another one with clean OOP design that will be traditionally landed. Review here should focus on correctness and edge cases that might not have been tested.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-1714
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Looks ok as a test. In the proper solution we should only enable multithreading in CommCoreModule constructor, just like we do for network GlobalNetworkSingleton::instance.enableMultithreading();.