Paths

Table of Contentst

[native] [0/34] ReactNav6: Type updated navigate function with default-unmerged params
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:09 AM.

Details

Reviewers

atul
tomek
bartek

Commits

rCOMM6970288ca2ca: [native] [0/34] ReactNav6: Type updated navigate function with default-unmerged…

Summary

Context on change here.

Change required specifying generics on all navigate calls unfortunately.

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 20 2022, 6:09 AM

Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:09 AM

ashoat added a child revision: D5394: [native] [1/34] ReactNav6: Drop "dangerously" from getParent and getState.Oct 20 2022, 6:09 AM

Harbormaster completed remote builds in B12880: Diff 17671.Oct 20 2022, 6:20 AM

ashoat requested review of this revision.Oct 20 2022, 6:20 AM

Skimmed the flow stuff, can do a more thorough review if that'd be helpful

This revision is now accepted and ready to land.Oct 20 2022, 9:12 AM

Closed by commit rCOMM6970288ca2ca: [native] [0/34] ReactNav6: Type updated navigate function with default-unmerged… (authored by ashoat). · Explain WhyOct 20 2022, 1:47 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6970288ca2ca: [native] [0/34] ReactNav6: Type updated navigate function with default-unmerged….

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

4 lines

chat-thread-list.react.js

2 lines

compose-thread-button.react.js

2 lines

message-list-header-title.react.js

2 lines

message-list-types.js

2 lines

multimedia-message.react.js

4 lines

robotext-message.react.js

2 lines

settings/

compose-subchannel-modal.react.js

4 lines

thread-settings-color.react.js

2 lines

thread-settings-delete-thread.react.js

2 lines

thread-settings-member.react.js

2 lines

sidebar-navigation.js

4 lines

text-message.react.js

2 lines

thread-settings-button.react.js

2 lines

flow-typed/

npm/

@react-navigation/

bottom-tabs_v5.x.x.js

55 lines

devtools_v5.x.x.js

55 lines

material-top-tabs_v5.x.x.js

55 lines

native_v5.x.x.js

55 lines

stack_v5.x.x.js

55 lines

profile/

relationship-list-item.react.js

2 lines

Diff 17756

View Options

native/chat/chat-input-bar.react.js

View Options

native/chat/chat-thread-list.react.js

View Options

native/chat/compose-thread-button.react.js

View Options

native/chat/message-list-header-title.react.js

View Options

native/chat/message-list-types.js

View Options

native/chat/multimedia-message.react.js

View Options

native/chat/robotext-message.react.js

View Options

native/chat/settings/compose-subchannel-modal.react.js

View Options

native/chat/settings/thread-settings-color.react.js

View Options

native/chat/settings/thread-settings-delete-thread.react.js

View Options

native/chat/settings/thread-settings-member.react.js

View Options

native/chat/sidebar-navigation.js

View Options

native/chat/text-message.react.js

View Options

native/chat/thread-settings-button.react.js

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

View Options

native/profile/relationship-list-item.react.js

[native] [0/34] ReactNav6: Type updated navigate function with default-unmerged paramsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17756

native/chat/chat-input-bar.react.js

native/chat/chat-thread-list.react.js

native/chat/compose-thread-button.react.js

native/chat/message-list-header-title.react.js

native/chat/message-list-types.js

native/chat/multimedia-message.react.js

native/chat/robotext-message.react.js

native/chat/settings/compose-subchannel-modal.react.js

native/chat/settings/thread-settings-color.react.js

native/chat/settings/thread-settings-delete-thread.react.js

native/chat/settings/thread-settings-member.react.js

native/chat/sidebar-navigation.js

native/chat/text-message.react.js

native/chat/thread-settings-button.react.js

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

native/profile/relationship-list-item.react.js

[native] [0/34] ReactNav6: Type updated navigate function with default-unmerged params
ClosedPublic
Actions

Revision Contents
Changeset List