Page MenuHomePhabricator
Differential D5422

[native] [29/34] ReactNav6: Merge tabBarOptions into options
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:19 AM.
Tags
None
Referenced Files
F5910217: D5422.id.diff
Thu, Apr 17, 3:59 PM
F5897262: D5422.id17785.diff
Thu, Apr 17, 11:22 AM
F5895208: D5422.id17700.diff
Thu, Apr 17, 10:41 AM
Unknown Object (File)
Tue, Apr 15, 11:08 PM
Unknown Object (File)
Wed, Apr 9, 3:25 AM
Unknown Object (File)
Wed, Apr 9, 3:25 AM
Unknown Object (File)
Wed, Apr 9, 3:25 AM
Unknown Object (File)
Wed, Apr 9, 3:24 AM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMM3924e11a9557: [native] [29/34] ReactNav6: Merge tabBarOptions into options
Summary

Context on change here.

Depends on D5421

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 20 2022, 6:19 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:19 AM
ashoat added a child revision: D5423: [native] [30/34] ReactNav6: Remove tabBarVisible option.Oct 20 2022, 6:20 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 6:42 AM
Harbormaster failed remote builds in B12909: Diff 17700!
ashoat requested review of this revision.Oct 20 2022, 7:25 AM

Build failures are caused by use of @react-navigation/elements in D5420, which isn't introduced until D5427. Sorry!!

atul accepted this revision.Oct 20 2022, 12:55 PM
This revision is now accepted and ready to land.Oct 20 2022, 12:55 PM
This revision was landed with ongoing or failed builds.Oct 20 2022, 1:47 PM
Closed by commit rCOMM3924e11a9557: [native] [29/34] ReactNav6: Merge tabBarOptions into options (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM3924e11a9557: [native] [29/34] ReactNav6: Merge tabBarOptions into options.

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
37 lines
37 lines
37 lines
37 lines
37 lines
37 lines
navigation/
13 lines

Diff 17785

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

native/flow-typed/npm/@react-navigation/elements_v1.x.x.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

native/navigation/app-navigator.react.js

Loading...