Page MenuHomePhabricator
Differential D5407

[native] [14/34] ReactNav6: make all screen params $ReadOnly
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 7:42 AM
Unknown Object (File)
Mar 2 2025, 10:39 PM
Unknown Object (File)
Mar 2 2025, 10:39 PM
Unknown Object (File)
Mar 2 2025, 10:26 PM
Unknown Object (File)
Feb 13 2025, 10:43 PM
Unknown Object (File)
Feb 13 2025, 10:43 PM
Unknown Object (File)
Feb 13 2025, 10:43 PM
Unknown Object (File)
Feb 13 2025, 10:43 PM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMM2ffc56ae63eb: [native] [14/34] ReactNav6: make all screen params $ReadOnly
Summary

We never got around to updating all of these. Noticed some non-$ReadOnly screen params while working on ReactNav6 types, so I decided to update all of them.

Depends on D5406

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 17770

View Options

native/calendar/thread-picker-modal.react.js

Show First 20 Lines • Show All 715 Lines • ▼ Show 20 Lines steps.push({
inputFilename: filename, inputFilename: filename,
outputMediaType: uploadResult && uploadResult.mediaType, outputMediaType: uploadResult && uploadResult.mediaType,
outputURI: uploadResult && uploadResult.uri, outputURI: uploadResult && uploadResult.uri,
outputDimensions: uploadResult && uploadResult.dimensions, outputDimensions: uploadResult && uploadResult.dimensions,
outputLoop: uploadResult && uploadResult.loop, outputLoop: uploadResult && uploadResult.loop,
hasWiFi, hasWiFi,
}); });
const promises = []; const cleanupPromises = [];
if (shouldDisposePath) { if (shouldDisposePath) {
// If processMedia needed to do any transcoding before upload, we dispose // If processMedia needed to do any transcoding before upload, we dispose
// of the resultant temporary file here. Since the transcoded temporary // of the resultant temporary file here. Since the transcoded temporary
// file is only used for upload, we can dispose of it after processMedia // file is only used for upload, we can dispose of it after processMedia
// (reportPromise) and the upload are complete // (reportPromise) and the upload are complete
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(shouldDisposePath); const disposeStep = await disposeTempFile(shouldDisposePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
// if there's a thumbnail we'll temporarily unlink it here // if there's a thumbnail we'll temporarily unlink it here
// instead of in media-utils, will be changed in later diffs // instead of in media-utils, will be changed in later diffs
if (processedMedia.mediaType === 'video') { if (processedMedia.mediaType === 'video') {
const { uploadThumbnailURI } = processedMedia; const { uploadThumbnailURI } = processedMedia;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(uploadThumbnailURI); const disposeStep = await disposeTempFile(uploadThumbnailURI);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
if (selection.captureTime || selection.step === 'photo_paste') { if (selection.captureTime || selection.step === 'photo_paste') {
// If we are uploading a newly captured photo, we dispose of the original // If we are uploading a newly captured photo, we dispose of the original
// file here. Note that we try to save photo captures to the camera roll // file here. Note that we try to save photo captures to the camera roll
// if we have permission. Even if we fail, this temporary file isn't // if we have permission. Even if we fail, this temporary file isn't
// visible to the user, so there's no point in keeping it around. Since // visible to the user, so there's no point in keeping it around. Since
// the initial URI is used in rendering paths, we have to wait for it to // the initial URI is used in rendering paths, we have to wait for it to
// be replaced with the remote URI before we can dispose. Check out the // be replaced with the remote URI before we can dispose. Check out the
// Multimedia component to see how the URIs get switched out. // Multimedia component to see how the URIs get switched out.
const captureURI = selection.uri; const captureURI = selection.uri;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const { const {
steps: clearSteps, steps: clearSteps,
result: capturePath, result: capturePath,
} = await this.waitForCaptureURIUnload(captureURI); } = await this.waitForCaptureURIUnload(captureURI);
steps.push(...clearSteps); steps.push(...clearSteps);
if (!capturePath) { if (!capturePath) {
return; return;
} }
const disposeStep = await disposeTempFile(capturePath); const disposeStep = await disposeTempFile(capturePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
await Promise.all(promises); await Promise.all(cleanupPromises);
return await onUploadFinished(mediaMissionResult); return await onUploadFinished(mediaMissionResult);
} }
mediaProcessConfig(localMessageID: string, localID: string) { mediaProcessConfig(localMessageID: string, localID: string) {
const { hasWiFi, viewerID } = this.props; const { hasWiFi, viewerID } = this.props;
const onTranscodingProgress = (percent: number) => { const onTranscodingProgress = (percent: number) => {
this.setProgress(localMessageID, localID, 'transcoding', percent); this.setProgress(localMessageID, localID, 'transcoding', percent);
▲ Show 20 Lines • Show All 579 Lines • Show Last 20 Lines
View Options

native/chat/settings/color-selector-modal.react.js

Show First 20 Lines • Show All 715 Lines • ▼ Show 20 Lines steps.push({
inputFilename: filename, inputFilename: filename,
outputMediaType: uploadResult && uploadResult.mediaType, outputMediaType: uploadResult && uploadResult.mediaType,
outputURI: uploadResult && uploadResult.uri, outputURI: uploadResult && uploadResult.uri,
outputDimensions: uploadResult && uploadResult.dimensions, outputDimensions: uploadResult && uploadResult.dimensions,
outputLoop: uploadResult && uploadResult.loop, outputLoop: uploadResult && uploadResult.loop,
hasWiFi, hasWiFi,
}); });
const promises = []; const cleanupPromises = [];
if (shouldDisposePath) { if (shouldDisposePath) {
// If processMedia needed to do any transcoding before upload, we dispose // If processMedia needed to do any transcoding before upload, we dispose
// of the resultant temporary file here. Since the transcoded temporary // of the resultant temporary file here. Since the transcoded temporary
// file is only used for upload, we can dispose of it after processMedia // file is only used for upload, we can dispose of it after processMedia
// (reportPromise) and the upload are complete // (reportPromise) and the upload are complete
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(shouldDisposePath); const disposeStep = await disposeTempFile(shouldDisposePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
// if there's a thumbnail we'll temporarily unlink it here // if there's a thumbnail we'll temporarily unlink it here
// instead of in media-utils, will be changed in later diffs // instead of in media-utils, will be changed in later diffs
if (processedMedia.mediaType === 'video') { if (processedMedia.mediaType === 'video') {
const { uploadThumbnailURI } = processedMedia; const { uploadThumbnailURI } = processedMedia;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(uploadThumbnailURI); const disposeStep = await disposeTempFile(uploadThumbnailURI);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
if (selection.captureTime || selection.step === 'photo_paste') { if (selection.captureTime || selection.step === 'photo_paste') {
// If we are uploading a newly captured photo, we dispose of the original // If we are uploading a newly captured photo, we dispose of the original
// file here. Note that we try to save photo captures to the camera roll // file here. Note that we try to save photo captures to the camera roll
// if we have permission. Even if we fail, this temporary file isn't // if we have permission. Even if we fail, this temporary file isn't
// visible to the user, so there's no point in keeping it around. Since // visible to the user, so there's no point in keeping it around. Since
// the initial URI is used in rendering paths, we have to wait for it to // the initial URI is used in rendering paths, we have to wait for it to
// be replaced with the remote URI before we can dispose. Check out the // be replaced with the remote URI before we can dispose. Check out the
// Multimedia component to see how the URIs get switched out. // Multimedia component to see how the URIs get switched out.
const captureURI = selection.uri; const captureURI = selection.uri;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const { const {
steps: clearSteps, steps: clearSteps,
result: capturePath, result: capturePath,
} = await this.waitForCaptureURIUnload(captureURI); } = await this.waitForCaptureURIUnload(captureURI);
steps.push(...clearSteps); steps.push(...clearSteps);
if (!capturePath) { if (!capturePath) {
return; return;
} }
const disposeStep = await disposeTempFile(capturePath); const disposeStep = await disposeTempFile(capturePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
await Promise.all(promises); await Promise.all(cleanupPromises);
return await onUploadFinished(mediaMissionResult); return await onUploadFinished(mediaMissionResult);
} }
mediaProcessConfig(localMessageID: string, localID: string) { mediaProcessConfig(localMessageID: string, localID: string) {
const { hasWiFi, viewerID } = this.props; const { hasWiFi, viewerID } = this.props;
const onTranscodingProgress = (percent: number) => { const onTranscodingProgress = (percent: number) => {
this.setProgress(localMessageID, localID, 'transcoding', percent); this.setProgress(localMessageID, localID, 'transcoding', percent);
▲ Show 20 Lines • Show All 579 Lines • Show Last 20 Lines
View Options

native/chat/settings/compose-subchannel-modal.react.js

Show First 20 Lines • Show All 715 Lines • ▼ Show 20 Lines steps.push({
inputFilename: filename, inputFilename: filename,
outputMediaType: uploadResult && uploadResult.mediaType, outputMediaType: uploadResult && uploadResult.mediaType,
outputURI: uploadResult && uploadResult.uri, outputURI: uploadResult && uploadResult.uri,
outputDimensions: uploadResult && uploadResult.dimensions, outputDimensions: uploadResult && uploadResult.dimensions,
outputLoop: uploadResult && uploadResult.loop, outputLoop: uploadResult && uploadResult.loop,
hasWiFi, hasWiFi,
}); });
const promises = []; const cleanupPromises = [];
if (shouldDisposePath) { if (shouldDisposePath) {
// If processMedia needed to do any transcoding before upload, we dispose // If processMedia needed to do any transcoding before upload, we dispose
// of the resultant temporary file here. Since the transcoded temporary // of the resultant temporary file here. Since the transcoded temporary
// file is only used for upload, we can dispose of it after processMedia // file is only used for upload, we can dispose of it after processMedia
// (reportPromise) and the upload are complete // (reportPromise) and the upload are complete
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(shouldDisposePath); const disposeStep = await disposeTempFile(shouldDisposePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
// if there's a thumbnail we'll temporarily unlink it here // if there's a thumbnail we'll temporarily unlink it here
// instead of in media-utils, will be changed in later diffs // instead of in media-utils, will be changed in later diffs
if (processedMedia.mediaType === 'video') { if (processedMedia.mediaType === 'video') {
const { uploadThumbnailURI } = processedMedia; const { uploadThumbnailURI } = processedMedia;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(uploadThumbnailURI); const disposeStep = await disposeTempFile(uploadThumbnailURI);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
if (selection.captureTime || selection.step === 'photo_paste') { if (selection.captureTime || selection.step === 'photo_paste') {
// If we are uploading a newly captured photo, we dispose of the original // If we are uploading a newly captured photo, we dispose of the original
// file here. Note that we try to save photo captures to the camera roll // file here. Note that we try to save photo captures to the camera roll
// if we have permission. Even if we fail, this temporary file isn't // if we have permission. Even if we fail, this temporary file isn't
// visible to the user, so there's no point in keeping it around. Since // visible to the user, so there's no point in keeping it around. Since
// the initial URI is used in rendering paths, we have to wait for it to // the initial URI is used in rendering paths, we have to wait for it to
// be replaced with the remote URI before we can dispose. Check out the // be replaced with the remote URI before we can dispose. Check out the
// Multimedia component to see how the URIs get switched out. // Multimedia component to see how the URIs get switched out.
const captureURI = selection.uri; const captureURI = selection.uri;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const { const {
steps: clearSteps, steps: clearSteps,
result: capturePath, result: capturePath,
} = await this.waitForCaptureURIUnload(captureURI); } = await this.waitForCaptureURIUnload(captureURI);
steps.push(...clearSteps); steps.push(...clearSteps);
if (!capturePath) { if (!capturePath) {
return; return;
} }
const disposeStep = await disposeTempFile(capturePath); const disposeStep = await disposeTempFile(capturePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
await Promise.all(promises); await Promise.all(cleanupPromises);
return await onUploadFinished(mediaMissionResult); return await onUploadFinished(mediaMissionResult);
} }
mediaProcessConfig(localMessageID: string, localID: string) { mediaProcessConfig(localMessageID: string, localID: string) {
const { hasWiFi, viewerID } = this.props; const { hasWiFi, viewerID } = this.props;
const onTranscodingProgress = (percent: number) => { const onTranscodingProgress = (percent: number) => {
this.setProgress(localMessageID, localID, 'transcoding', percent); this.setProgress(localMessageID, localID, 'transcoding', percent);
▲ Show 20 Lines • Show All 579 Lines • Show Last 20 Lines
View Options

native/media/image-modal.react.js

Show First 20 Lines • Show All 715 Lines • ▼ Show 20 Lines steps.push({
inputFilename: filename, inputFilename: filename,
outputMediaType: uploadResult && uploadResult.mediaType, outputMediaType: uploadResult && uploadResult.mediaType,
outputURI: uploadResult && uploadResult.uri, outputURI: uploadResult && uploadResult.uri,
outputDimensions: uploadResult && uploadResult.dimensions, outputDimensions: uploadResult && uploadResult.dimensions,
outputLoop: uploadResult && uploadResult.loop, outputLoop: uploadResult && uploadResult.loop,
hasWiFi, hasWiFi,
}); });
const promises = []; const cleanupPromises = [];
if (shouldDisposePath) { if (shouldDisposePath) {
// If processMedia needed to do any transcoding before upload, we dispose // If processMedia needed to do any transcoding before upload, we dispose
// of the resultant temporary file here. Since the transcoded temporary // of the resultant temporary file here. Since the transcoded temporary
// file is only used for upload, we can dispose of it after processMedia // file is only used for upload, we can dispose of it after processMedia
// (reportPromise) and the upload are complete // (reportPromise) and the upload are complete
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(shouldDisposePath); const disposeStep = await disposeTempFile(shouldDisposePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
// if there's a thumbnail we'll temporarily unlink it here // if there's a thumbnail we'll temporarily unlink it here
// instead of in media-utils, will be changed in later diffs // instead of in media-utils, will be changed in later diffs
if (processedMedia.mediaType === 'video') { if (processedMedia.mediaType === 'video') {
const { uploadThumbnailURI } = processedMedia; const { uploadThumbnailURI } = processedMedia;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(uploadThumbnailURI); const disposeStep = await disposeTempFile(uploadThumbnailURI);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
if (selection.captureTime || selection.step === 'photo_paste') { if (selection.captureTime || selection.step === 'photo_paste') {
// If we are uploading a newly captured photo, we dispose of the original // If we are uploading a newly captured photo, we dispose of the original
// file here. Note that we try to save photo captures to the camera roll // file here. Note that we try to save photo captures to the camera roll
// if we have permission. Even if we fail, this temporary file isn't // if we have permission. Even if we fail, this temporary file isn't
// visible to the user, so there's no point in keeping it around. Since // visible to the user, so there's no point in keeping it around. Since
// the initial URI is used in rendering paths, we have to wait for it to // the initial URI is used in rendering paths, we have to wait for it to
// be replaced with the remote URI before we can dispose. Check out the // be replaced with the remote URI before we can dispose. Check out the
// Multimedia component to see how the URIs get switched out. // Multimedia component to see how the URIs get switched out.
const captureURI = selection.uri; const captureURI = selection.uri;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const { const {
steps: clearSteps, steps: clearSteps,
result: capturePath, result: capturePath,
} = await this.waitForCaptureURIUnload(captureURI); } = await this.waitForCaptureURIUnload(captureURI);
steps.push(...clearSteps); steps.push(...clearSteps);
if (!capturePath) { if (!capturePath) {
return; return;
} }
const disposeStep = await disposeTempFile(capturePath); const disposeStep = await disposeTempFile(capturePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
await Promise.all(promises); await Promise.all(cleanupPromises);
return await onUploadFinished(mediaMissionResult); return await onUploadFinished(mediaMissionResult);
} }
mediaProcessConfig(localMessageID: string, localID: string) { mediaProcessConfig(localMessageID: string, localID: string) {
const { hasWiFi, viewerID } = this.props; const { hasWiFi, viewerID } = this.props;
const onTranscodingProgress = (percent: number) => { const onTranscodingProgress = (percent: number) => {
this.setProgress(localMessageID, localID, 'transcoding', percent); this.setProgress(localMessageID, localID, 'transcoding', percent);
▲ Show 20 Lines • Show All 579 Lines • Show Last 20 Lines
View Options

native/navigation/action-result-modal.react.js

Show First 20 Lines • Show All 715 Lines • ▼ Show 20 Lines steps.push({
inputFilename: filename, inputFilename: filename,
outputMediaType: uploadResult && uploadResult.mediaType, outputMediaType: uploadResult && uploadResult.mediaType,
outputURI: uploadResult && uploadResult.uri, outputURI: uploadResult && uploadResult.uri,
outputDimensions: uploadResult && uploadResult.dimensions, outputDimensions: uploadResult && uploadResult.dimensions,
outputLoop: uploadResult && uploadResult.loop, outputLoop: uploadResult && uploadResult.loop,
hasWiFi, hasWiFi,
}); });
const promises = []; const cleanupPromises = [];
if (shouldDisposePath) { if (shouldDisposePath) {
// If processMedia needed to do any transcoding before upload, we dispose // If processMedia needed to do any transcoding before upload, we dispose
// of the resultant temporary file here. Since the transcoded temporary // of the resultant temporary file here. Since the transcoded temporary
// file is only used for upload, we can dispose of it after processMedia // file is only used for upload, we can dispose of it after processMedia
// (reportPromise) and the upload are complete // (reportPromise) and the upload are complete
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(shouldDisposePath); const disposeStep = await disposeTempFile(shouldDisposePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
// if there's a thumbnail we'll temporarily unlink it here // if there's a thumbnail we'll temporarily unlink it here
// instead of in media-utils, will be changed in later diffs // instead of in media-utils, will be changed in later diffs
if (processedMedia.mediaType === 'video') { if (processedMedia.mediaType === 'video') {
const { uploadThumbnailURI } = processedMedia; const { uploadThumbnailURI } = processedMedia;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(uploadThumbnailURI); const disposeStep = await disposeTempFile(uploadThumbnailURI);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
if (selection.captureTime || selection.step === 'photo_paste') { if (selection.captureTime || selection.step === 'photo_paste') {
// If we are uploading a newly captured photo, we dispose of the original // If we are uploading a newly captured photo, we dispose of the original
// file here. Note that we try to save photo captures to the camera roll // file here. Note that we try to save photo captures to the camera roll
// if we have permission. Even if we fail, this temporary file isn't // if we have permission. Even if we fail, this temporary file isn't
// visible to the user, so there's no point in keeping it around. Since // visible to the user, so there's no point in keeping it around. Since
// the initial URI is used in rendering paths, we have to wait for it to // the initial URI is used in rendering paths, we have to wait for it to
// be replaced with the remote URI before we can dispose. Check out the // be replaced with the remote URI before we can dispose. Check out the
// Multimedia component to see how the URIs get switched out. // Multimedia component to see how the URIs get switched out.
const captureURI = selection.uri; const captureURI = selection.uri;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const { const {
steps: clearSteps, steps: clearSteps,
result: capturePath, result: capturePath,
} = await this.waitForCaptureURIUnload(captureURI); } = await this.waitForCaptureURIUnload(captureURI);
steps.push(...clearSteps); steps.push(...clearSteps);
if (!capturePath) { if (!capturePath) {
return; return;
} }
const disposeStep = await disposeTempFile(capturePath); const disposeStep = await disposeTempFile(capturePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
await Promise.all(promises); await Promise.all(cleanupPromises);
return await onUploadFinished(mediaMissionResult); return await onUploadFinished(mediaMissionResult);
} }
mediaProcessConfig(localMessageID: string, localID: string) { mediaProcessConfig(localMessageID: string, localID: string) {
const { hasWiFi, viewerID } = this.props; const { hasWiFi, viewerID } = this.props;
const onTranscodingProgress = (percent: number) => { const onTranscodingProgress = (percent: number) => {
this.setProgress(localMessageID, localID, 'transcoding', percent); this.setProgress(localMessageID, localID, 'transcoding', percent);
▲ Show 20 Lines • Show All 579 Lines • Show Last 20 Lines
View Options

native/profile/custom-server-modal.react.js

Show First 20 Lines • Show All 715 Lines • ▼ Show 20 Lines steps.push({
inputFilename: filename, inputFilename: filename,
outputMediaType: uploadResult && uploadResult.mediaType, outputMediaType: uploadResult && uploadResult.mediaType,
outputURI: uploadResult && uploadResult.uri, outputURI: uploadResult && uploadResult.uri,
outputDimensions: uploadResult && uploadResult.dimensions, outputDimensions: uploadResult && uploadResult.dimensions,
outputLoop: uploadResult && uploadResult.loop, outputLoop: uploadResult && uploadResult.loop,
hasWiFi, hasWiFi,
}); });
const promises = []; const cleanupPromises = [];
if (shouldDisposePath) { if (shouldDisposePath) {
// If processMedia needed to do any transcoding before upload, we dispose // If processMedia needed to do any transcoding before upload, we dispose
// of the resultant temporary file here. Since the transcoded temporary // of the resultant temporary file here. Since the transcoded temporary
// file is only used for upload, we can dispose of it after processMedia // file is only used for upload, we can dispose of it after processMedia
// (reportPromise) and the upload are complete // (reportPromise) and the upload are complete
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(shouldDisposePath); const disposeStep = await disposeTempFile(shouldDisposePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
// if there's a thumbnail we'll temporarily unlink it here // if there's a thumbnail we'll temporarily unlink it here
// instead of in media-utils, will be changed in later diffs // instead of in media-utils, will be changed in later diffs
if (processedMedia.mediaType === 'video') { if (processedMedia.mediaType === 'video') {
const { uploadThumbnailURI } = processedMedia; const { uploadThumbnailURI } = processedMedia;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const disposeStep = await disposeTempFile(uploadThumbnailURI); const disposeStep = await disposeTempFile(uploadThumbnailURI);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
if (selection.captureTime || selection.step === 'photo_paste') { if (selection.captureTime || selection.step === 'photo_paste') {
// If we are uploading a newly captured photo, we dispose of the original // If we are uploading a newly captured photo, we dispose of the original
// file here. Note that we try to save photo captures to the camera roll // file here. Note that we try to save photo captures to the camera roll
// if we have permission. Even if we fail, this temporary file isn't // if we have permission. Even if we fail, this temporary file isn't
// visible to the user, so there's no point in keeping it around. Since // visible to the user, so there's no point in keeping it around. Since
// the initial URI is used in rendering paths, we have to wait for it to // the initial URI is used in rendering paths, we have to wait for it to
// be replaced with the remote URI before we can dispose. Check out the // be replaced with the remote URI before we can dispose. Check out the
// Multimedia component to see how the URIs get switched out. // Multimedia component to see how the URIs get switched out.
const captureURI = selection.uri; const captureURI = selection.uri;
promises.push( cleanupPromises.push(
(async () => { (async () => {
const { const {
steps: clearSteps, steps: clearSteps,
result: capturePath, result: capturePath,
} = await this.waitForCaptureURIUnload(captureURI); } = await this.waitForCaptureURIUnload(captureURI);
steps.push(...clearSteps); steps.push(...clearSteps);
if (!capturePath) { if (!capturePath) {
return; return;
} }
const disposeStep = await disposeTempFile(capturePath); const disposeStep = await disposeTempFile(capturePath);
steps.push(disposeStep); steps.push(disposeStep);
})(), })(),
); );
} }
await Promise.all(promises); await Promise.all(cleanupPromises);
return await onUploadFinished(mediaMissionResult); return await onUploadFinished(mediaMissionResult);
} }
mediaProcessConfig(localMessageID: string, localID: string) { mediaProcessConfig(localMessageID: string, localID: string) {
const { hasWiFi, viewerID } = this.props; const { hasWiFi, viewerID } = this.props;
const onTranscodingProgress = (percent: number) => { const onTranscodingProgress = (percent: number) => {
this.setProgress(localMessageID, localID, 'transcoding', percent); this.setProgress(localMessageID, localID, 'transcoding', percent);
▲ Show 20 Lines • Show All 579 Lines • Show Last 20 Lines