Page MenuHomePhabricator

[native] [28/34] ReactNav6: Specify headerShown: false for tab bar
ClosedPublic

Authored by ashoat on Oct 20 2022, 6:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 9:07 PM
Unknown Object (File)
Wed, Nov 27, 9:07 PM
Unknown Object (File)
Tue, Nov 26, 5:24 AM
Unknown Object (File)
Mon, Nov 25, 11:47 AM
Unknown Object (File)
Sun, Nov 24, 1:21 AM
Unknown Object (File)
Nov 11 2024, 1:51 AM
Unknown Object (File)
Nov 3 2024, 5:38 PM
Unknown Object (File)
Oct 6 2024, 1:45 AM
Subscribers

Details

Summary

Context on change here.

Depends on D5420

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 6:41 AM
Harbormaster failed remote builds in B12908: Diff 17699!

Build failures are caused by use of @react-navigation/elements in D5420, which isn't introduced until D5427. Sorry!!

This revision is now accepted and ready to land.Oct 20 2022, 12:54 PM
This revision was landed with ongoing or failed builds.Oct 20 2022, 1:47 PM
This revision was automatically updated to reflect the committed changes.