[native] [1/34] ReactNav6: Drop "dangerously" from getParent and getState
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:09 AM.

Details

Reviewers

atul
tomek
bartek

Commits

rCOMM572a4a4d0290: [native] [1/34] ReactNav6: Drop "dangerously" from getParent and getState

Summary

Context on change here.

Depends on D5393

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 20 2022, 6:09 AM

Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:10 AM

ashoat added a child revision: D5395: [native] [2/34] ReactNav6: added new path property to Route prop.Oct 20 2022, 6:10 AM

Harbormaster completed remote builds in B12881: Diff 17672.Oct 20 2022, 6:20 AM

ashoat requested review of this revision.Oct 20 2022, 6:20 AM

Looks like a straightforward find and replace

This revision is now accepted and ready to land.Oct 20 2022, 9:13 AM

Closed by commit rCOMM572a4a4d0290: [native] [1/34] ReactNav6: Drop "dangerously" from getParent and getState (authored by ashoat). · Explain WhyOct 20 2022, 1:47 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM572a4a4d0290: [native] [1/34] ReactNav6: Drop "dangerously" from getParent and getState.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-list.react.js

4 lines

chat-thread-list.react.js

8 lines

settings/

thread-settings.react.js

4 lines

flow-typed/

npm/

@react-navigation/

bottom-tabs_v5.x.x.js

4 lines

devtools_v5.x.x.js

4 lines

material-top-tabs_v5.x.x.js

4 lines

native_v5.x.x.js

4 lines

stack_v5.x.x.js

4 lines

Diff 17758

View Options

native/chat/chat-list.react.js

View Options

native/chat/chat-thread-list.react.js

View Options

native/chat/settings/thread-settings.react.js

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

[native] [1/34] ReactNav6: Drop "dangerously" from getParent and getStateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17758

native/chat/chat-list.react.js

native/chat/chat-thread-list.react.js

native/chat/settings/thread-settings.react.js

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

[native] [1/34] ReactNav6: Drop "dangerously" from getParent and getState
ClosedPublic
Actions

Revision Contents
Changeset List