Page MenuHomePhabricator
Differential D5415

[native] [22/34] ReactNav6: Move keyboardHandlingEnabled to StackOptions
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 5:18 PM
Unknown Object (File)
Fri, Dec 27, 5:18 PM
Unknown Object (File)
Fri, Dec 27, 5:17 PM
Unknown Object (File)
Fri, Dec 27, 4:57 PM
Unknown Object (File)
Wed, Dec 25, 1:01 PM
Unknown Object (File)
Nov 26 2024, 5:13 PM
Unknown Object (File)
Nov 26 2024, 5:13 PM
Unknown Object (File)
Nov 26 2024, 5:13 PM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMMdb12d5c662dd: [native] [22/34] ReactNav6: Move keyboardHandlingEnabled to StackOptions
Summary

Context on change here.

Depends on D5414

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 20 2022, 6:17 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:17 AM
ashoat added a child revision: D5416: [native] [23/34] ReactNav6: Replace mode="modal" with presentation: 'modal'.Oct 20 2022, 6:18 AM
Harbormaster completed remote builds in B12902: Diff 17693.Oct 20 2022, 7:03 AM
ashoat requested review of this revision.Oct 20 2022, 7:03 AM
atul accepted this revision.Oct 20 2022, 12:47 PM

Is "keyboard handling" something we should keep an eye on when we make the internal release?

This revision is now accepted and ready to land.Oct 20 2022, 12:47 PM
ashoat added a comment.Oct 20 2022, 12:54 PM

Potentially. The only place this comes up is the ThreadPickerModal for the calendar. Ideally everything should continue working the same as it has before...

Closed by commit rCOMMdb12d5c662dd: [native] [22/34] ReactNav6: Move keyboardHandlingEnabled to StackOptions (authored by ashoat). · Explain WhyOct 20 2022, 1:47 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMdb12d5c662dd: [native] [22/34] ReactNav6: Move keyboardHandlingEnabled to StackOptions.

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
2 lines
2 lines
2 lines
2 lines
2 lines
navigation/
22 lines

Diff 17778

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...
View Options

native/navigation/root-navigator.react.js

Loading...